Create helm PR using a github app server/#3658 #604
Conversation
gsavage
left a comment
gsavage
left a comment
There was a problem hiding this comment.
I'm not sure I understand, from the commit message, what this change is, or why we've done it.
The commit message says we're generating a PR from a github app, but it looks like we're still generating the PR from the peter-evans action, but using a token generated using a github-provided action. I can't tell from the PR why we've made this change.
Also, I see that previously we had Jon as the author, but now there isn't an author and that it's no longer marked as "signoff: false" - could we have said what those fields default to now?
|
|
||
| ---------------------------------------------- | ||
| Autogenerated from chart metadata using [helm-docs v1.5.0](https://github.com/norwoodj/helm-docs/releases/v1.5.0) | ||
|
|
There was a problem hiding this comment.
Unnecessary blank line
Ah, I see this was to trigger the build.
| - uses: crazy-max/ghaction-import-gpg@v5 | ||
| with: | ||
| gpg_private_key: ${{ secrets.GPG_PRIVATE_KEY }} | ||
| passphrase: ${{ secrets.GPG_PASSPHRASE }} |
There was a problem hiding this comment.
Do we need to remove these secrets from the repository now?
There was a problem hiding this comment.
I will in due time.
No description provided.