Skip to content

Fix(security): Replace vulnerable XML parsing with defusedxml library #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
orca-security-eu wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix(security): Replace vulnerable XML parsing with defusedxml library #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions env/lib/python3.9/site-packages/py/_path/svnwc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1107,8 +1107,7 @@ def fromstring(data, rootwcpath, rev=None, modrev=None, author=None):

if wcpath == rootwcpath:
rootstatus.rev = rev
rootstatus.modrev = modrev
rootstatus.author = author
rootstatus.modrev = modrevrootstatus.author = author
rootstatus.date = date

# handle repos-status element (remote info)
Expand Down Expand Up @@ -1207,9 +1206,9 @@ def make_recursive_propdict(wcroot,
def importxml(cache=[]):
if cache:
return cache
from xml.dom import minidom
from defusedxml.minidom import parse, parseString
from xml.parsers.expat import ExpatError
cache.extend([minidom, ExpatError])
cache.extend([parse, parseString, ExpatError])
return cache

class LogEntry:
Expand All @@ -1236,5 +1235,3 @@ def __init__(self, logentry):
def __repr__(self):
return '<Logentry rev=%d author=%s date=%s>' % (
self.rev, self.author, self.date)