Dan feedback - Lab 1 #2
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Initial commit fails on my templated repo, see below: |
Contributor
Author
|
Maybe you already have considered it, but https://ttl.sh/ could also be used as registry. It is super nice to have it in ghcr though, it was just to avoid permissions, etc. |
Contributor
Author
|
After latest two commits on my fork: |
Contributor
Author
|
Latest commit fixes below in my fork: |
Contributor
Author
|
Deployment job also works now in my fork from latest commit: |
Contributor
Author
|
The failing jobs are because I forked the this repo to a private repo under my user. |
Collaborator
|
Thanks for the contribution @dangrondahl 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My feedback either as code/doc edits or in the chat