feat: install apiserver-network-proxy when create virtualCluster #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
village-way
changed the title
duanmengkk
reviewed
May 20, 2024
pkg/kubenest/manifest/controlplane/apiserver/mainfests_deployment.go
Outdated
Show resolved
Hide resolved
duanmengkk
reviewed
May 20, 2024
pkg/kubenest/manifest/controlplane/apiserver/mainfests_deployment.go
Outdated
Show resolved
Hide resolved
duanmengkk
reviewed
May 20, 2024
OrangeBao
reviewed
May 21, 2024
village-way
force-pushed
the
main
branch
6 times, most recently
from
280f71b to
a51a604
Compare
|
/approve |
|
/lgtm |
Signed-off-by: wangdepeng <[email protected]>
Signed-off-by: wangdepeng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What does this PR do?
Which issue(s) does this PR fix?
Fixes #568 #571
Special notes for your reviewer:
Does this PR introduce a user-facing change?