-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upstream of updates and misc improvements #45
base: master
Are you sure you want to change the base?
Conversation
…abel name Finagle stats dont have a way to propagate custom metadata, so this is a hacky workaround
Hello! here is a detailed list of all the changes: Most importantly: Support Prometheus labels and values (metadata for metrics) Given that the way this library currently works of exporting Twitter metrics to Prometheus metrics we had to piggyback on Twitter metric names to include the list of labels and values as URL parameters, and parse them out and expose them with the right format for Prometheus. This implementation is backwards compatible with existing integrations, and in order to be able to expose metadata to prometheus, just use the Misc changes:
|
Upgrades to Scala 2.13 and latest libs (twitterVersion to latest 22.12.0)