Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream of updates and misc improvements #45

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

fabianhjr
Copy link

@fabianhjr fabianhjr commented Jan 9, 2023

Upgrades to Scala 2.13 and latest libs (twitterVersion to latest 22.12.0)

@davoclavo
Copy link

davoclavo commented Jan 9, 2023

Hello! here is a detailed list of all the changes:

Most importantly: Support Prometheus labels and values (metadata for metrics)

Given that the way this library currently works of exporting Twitter metrics to Prometheus metrics we had to piggyback on Twitter metric names to include the list of labels and values as URL parameters, and parse them out and expose them with the right format for Prometheus. This implementation is backwards compatible with existing integrations, and in order to be able to expose metadata to prometheus, just use the toMetricName method that will add a List[(String, String)] as URL parameters to the twitter metric name.

Misc changes:

  • Add support for Scala 2.13.10
  • Update sbt to 1.8.0
  • Update Twitter libraries to 22.12.0
  • Update Prometheus client to 0.16.0
  • Update Logback classic to 1.4.5
  • Update scalatest to 3.2.14
  • Replace class + object to a case class to have an automatically generated constructor companion object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants