-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jorge/fix multiword surnames #213
Conversation
Is this ready to be merged? I looked at the bibfile and it looks okay. |
How do you decide what is the old and new entry? |
If you agree with the new format, it is ready. For the lack of safety with edited ones, I trust people know what they are doing. Or do we need some extra safety measure? (see below) |
How do you decide what is the old and new entry? It does not distinguish between old and new entries. Only between names with multi-word last names are otherwise. It does not have a safe measure if someone decides to introduce a wrongly edited one. For instance, if the bibliography contains an entry with the name I trust people know what they are doing, and that in the worst case, this will not be merged. Or do we need some extra safety measures? |
To explicitly mark the correct one, we would need a separate file with author names. Since I do not trust that everyone opening PRs here really has an eye for such kind of details, I would like to delegate this question to @tortinator. He is usually the one doing the final merge. |
Hi @jorgefandinno and @rkaminsk, thanks for your great efforts! What would be needed as well is a concise description that we could put into our documentation for the other members in the group. |
bibtex distinguish between first="D."
von="Van"
last="Nieuwenborgh" while first="D."
von=""
last="Van Nieuwenborgh" My understanding is that entries should be in order according to the
and It will also help in the future to produce keys of entries automatically. The key for this entry took |
I'd follow the recommended way here. My two cents regarding broken bibtex styles: that's for the editor to fix. |
522de61
to
90483b3
Compare
@tortinator, added a description to the README. |
@tortinator Are we missing something to merge? |
I'll have a look and take care of merging. |
All good @jorgefandinno , I am just busy and asked @rkaminsk to care about putting things in place 😇 |
b1aaa4e
to
3e0d7f6
Compare
Hi @jorgefandinno, I tried to streamline and refactor a bit. If this is okay for you, I would merge. |
4ddd558
to
b587a44
Compare
It looks good to me. I would pin the version in the README for: pip install bibtexparser because there is a new API incompatible version |
Seems like we have to upgrade at some point. But let's not do it now. |
4d61f26
to
f923f14
Compare
f923f14
to
6241634
Compare
Done. Hope it will work. 🤞 |
This closes #184 regarding multi-word last names. It also fixes inconsistencies with the von part in many names.
For instance, both
K. von Luck
andK. {von Luck}
appeared inkrr.bib
and should be written as the former.Similarly, names with capitalized von parts such as
D. {Van Nieuwenborgh}
should be written asD. {V}an Nieuwenborgh
(https://us.mirrors.cicku.me/ctan/info/bibtex/tamethebeast/ttb_en.pdf, page 26).The conversion can be automatically applied again if needed by the command
The folder
last_name_format_transition
and its content can be removed after this is merged.The script
authfmt.py
has been updated to produce the new format.