Use chainguard dev image and set Pod Security Standard to restricted profile for the Kubecost copier#32
Open
avrodrigues5 wants to merge 2 commits into
Open
Use chainguard dev image and set Pod Security Standard to restricted profile for the Kubecost copier#32avrodrigues5 wants to merge 2 commits into
avrodrigues5 wants to merge 2 commits into
Conversation
…m a yaml template, change log level of number of runs from debug to info as info is default
chipzoller
reviewed
May 23, 2024
chipzoller
left a comment
Collaborator
There was a problem hiding this comment.
Glad to see the CI is already paying off.
Can we add resource requests and limits here so the copier gets the highest level of QoS? I don't imagine, even with large datasets, there is a particularly large amount of CPU or memory consumed. Have you done any profiling/monitoring here to get a sense of what we could configure?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Does this PR rely on any other PRs?
None
How does this PR impact users?
Better security profile for the intermediate copier pod
Links to Issues or tickets this PR addresses or fixes
Closes #8
What risks are associated with merging this PR? What is required to fully test this PR?
It was tested for scale up and scale down operation
The pod that gets created has following yaml
How was this PR tested?
Creating two deployments and waiting on kubecost to recommend and then letting the DIsk auto scaler do its respective function.