Skip to content
This repository has been archived by the owner on Aug 17, 2023. It is now read-only.

Commit

Permalink
Add daemonset status check support (#434)
Browse files Browse the repository at this point in the history
  • Loading branch information
Yao Xiao authored Nov 11, 2020
1 parent 3e8807d commit fed86c8
Showing 1 changed file with 14 additions and 0 deletions.
14 changes: 14 additions & 0 deletions py/kubeflow/kfctl/testing/pytests/kf_is_ready_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,8 @@ def test_kf_is_ready(record_xml_attribute, namespace, use_basic_auth,

stateful_set_names = []

daemon_set_names = []

platform, _ = get_platform_app_name(app_path)

# TODO(PatrickXYS): not sure why istio-galley can't found
Expand Down Expand Up @@ -233,6 +235,7 @@ def test_kf_is_ready(record_xml_attribute, namespace, use_basic_auth,
elif platform == "aws":
# TODO(PatrickXYS): Extend List with AWS Deployment
deployment_names.extend(["alb-ingress-controller"])
daemon_set_names.extend(["nvidia-device-plugin-daemonset"])

# TODO(jlewi): Might want to parallelize this.
for deployment_name in deployment_names:
Expand All @@ -256,6 +259,17 @@ def test_kf_is_ready(record_xml_attribute, namespace, use_basic_auth,
util.run(["kubectl", "-n", ss_namespace, "describe", "statefulsets", name])
raise

all_daemon_sets = [(namespace, name) for name in daemon_set_names]

for ds_namespace, name in all_daemon_sets:
logging.info("Verifying that daemonset set %s.%s started...", ds_namespace, name)
try:
util.wait_for_daemonset(api_client, ds_namespace, name)
except:
# Collect debug information by running describe
util.run(["kubectl", "-n", ds_namespace, "describe", "daemonset", name])
raise

ingress_names = ["istio-ingress"]
# Check if Ingress is Ready and Healthy
if platform in ["aws"]:
Expand Down

0 comments on commit fed86c8

Please sign in to comment.