Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update kind config #2971

Merged

Conversation

warjiang
Copy link
Contributor

@warjiang warjiang commented Feb 2, 2025

Fix kind config in the install instructions

✏️ A brief description of the changes

Follow the install instructions 👉🏻: https://github.com/kubeflow/manifests?tab=readme-ov-file#install-with-a-single-command
but the cluster-jwks-proxy not works due to the wrong config for kind cluster, the kubernetes.default.svc issuer should be corrected as https://kubernetes.default.svc

📦 List any dependencies that are required for this change

My PR depends on #

None

🐛 If this PR is related to an issue, please put the link to the issue here.

The following issues are related, because ...

#2963

✅ Contributor checklist


You can join the CNCF Slack and access our meetings at the Kubeflow Community website. Our channel on the CNCF Slack is here #kubeflow-platform.

@juliusvonkohout
Copy link
Member

@warjiang thank you for the PR, but you need to modify

\"service-account-issuer\": \"kubernetes.default.svc\"
as well such that all our tests run.

@juliusvonkohout juliusvonkohout linked an issue Feb 3, 2025 that may be closed by this pull request
7 tasks
@warjiang
Copy link
Contributor Author

warjiang commented Feb 3, 2025

@warjiang thank you for the PR, but you need to modify

\"service-account-issuer\": \"kubernetes.default.svc\"

as well such that all our tests run.

Thanks for your kindly reminder~ config for KinD in tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh updated, plz recheck it again.

Signed-off-by: warjiang <[email protected]>
@warjiang warjiang force-pushed the fix/cluster-jwks-proxy-by-kind branch from dfe41e2 to 588e49e Compare February 3, 2025 17:27
@juliusvonkohout
Copy link
Member

/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 550e0b3 into kubeflow:master Feb 4, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Startup probe on cluster-jwks-proxy fails with an HTTP 404 error
2 participants