Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add trainedmodels custom resource to kubeflow-kserve clusterroles #2975

Conversation

gigabyte132
Copy link

Pull Request Template for Kubeflow manifests Issues

✏️ A brief description of the changes

Added the trainedmodels custom resource to the kubeflow-kserve-edit and kubeflow-kserve-view cluster roles so that users can create/view TrainedModel type resources.

📦 List any dependencies that are required for this change

No other changes are required, I have built the custom manifest and tested on my kubeflow cluster.

🐛 If this PR is related to an issue, please put the link to the issue here.

This closes issue #2974

✅ Contributor checklist


You can join the CNCF Slack and access our meetings at the Kubeflow Community website. Our channel on the CNCF Slack is here #kubeflow-platform.

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign yuzisun for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@juliusvonkohout
Copy link
Member

Please do not modify contrib/kserve/kserve/kserve_kubeflow.yaml directly. This must be fixed upstream and synchronized here with https://github.com/kubeflow/manifests/blob/master/hack/synchronize-kserve-kserve-manifests.sh. So fix it upstream first please

@juliusvonkohout
Copy link
Member

/hold

@gigabyte132
Copy link
Author

gigabyte132 commented Feb 4, 2025

Please do not modify contrib/kserve/kserve/kserve_kubeflow.yaml directly. This must be fixed upstream and synchronized here with https://github.com/kubeflow/manifests/blob/master/hack/synchronize-kserve-kserve-manifests.sh. So fix it upstream first please

Sounds good, will do, sorry.

@gigabyte132 gigabyte132 closed this Feb 4, 2025
@juliusvonkohout juliusvonkohout self-assigned this Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants