-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
demo storing label as custom property with empty string value #53
demo storing label as custom property with empty string value #53
Conversation
In this demo, RegisteredModel gets labels: my-label1, my-label2 ModelVersion gets labels: my-label3, my-label4 ModelArtifact gets labels: my-label5, my-label6 Signed-off-by: Matteo Mortari <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@dhirajsb: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhirajsb, rareddy, tarilabs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* This commit will change the success label for a 404 return to a yellow warning. * removing double echo
In this demo,
Description
Custom property of type string, with empty string value, shall be considered a Label; this is also semantically compatible for properties having empty string values in general.
How Has This Been Tested?
Behind the scenes, request payload is exercised as:
So we can notice this takes the general form of:
And analogous response:
Resulting in:
as expected.
References:
labels
in the openapi models opendatahub-io/model-registry-bf4-kf#151Merge criteria: