-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): bump github.com/testcontainers/testcontainers-go from 0.26.0 to 0.30.0 #57
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dependabot[bot] The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This update is on hold: this requires Go >= 1.20.
There is also opportunity then to change deprecated method:
diff --git a/internal/testutils/test_container_utils.go b/internal/testutils/test_container_utils.go
index 42671550..c3ee82c7 100644
--- a/internal/testutils/test_container_utils.go
+++ b/internal/testutils/test_container_utils.go
@@ -7,6 +7,7 @@ import (
"os"
"testing"
+ "github.com/docker/docker/api/types/container"
"github.com/opendatahub-io/model-registry/internal/ml_metadata/proto"
"github.com/testcontainers/testcontainers-go"
"github.com/testcontainers/testcontainers-go/wait"
@@ -82,13 +83,8 @@ func SetupMLMetadataTestContainer(t *testing.T) (*grpc.ClientConn, proto.Metadat
Env: map[string]string{
"METADATA_STORE_SERVER_CONFIG_FILE": "/tmp/shared/conn_config.pb",
},
- Mounts: testcontainers.ContainerMounts{
- testcontainers.ContainerMount{
- Source: testcontainers.GenericBindMountSource{
- HostPath: wd,
- },
- Target: "/tmp/shared",
- },
+ HostConfigModifier: func(hc *container.HostConfig) {
+ hc.Binds = []string{wd + ":/tmp/shared"}
},
WaitingFor: wait.ForLog("Server listening on"),
}
bumping Go version would also "incorporate" these changes:
3b31013
to
d92b241
Compare
Bumps [github.com/testcontainers/testcontainers-go](https://github.com/testcontainers/testcontainers-go) from 0.26.0 to 0.30.0. - [Release notes](https://github.com/testcontainers/testcontainers-go/releases) - [Commits](testcontainers/testcontainers-go@v0.26.0...v0.30.0) --- updated-dependencies: - dependency-name: github.com/testcontainers/testcontainers-go dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
d92b241
to
82d2856
Compare
Superseded by #80. |
Bumps github.com/testcontainers/testcontainers-go from 0.26.0 to 0.30.0.
Release notes
Sourced from github.com/testcontainers/testcontainers-go's releases.
... (truncated)
Commits
fe33f3a
chore: use new version (v0.30.0) in modules and examples4a079a0
Fix url creation to handle query params when using HTTP wait strategy (#2466)8ee975e
fix: data race on container run (#2345)e8b8e55
fix: logging deadlock (#2346)55ca42a
feat(k6):Add remote test scripts (#2350)697c264
feat: optimizes file copies to and from containers (#2450)88622f0
fix(exec): updates theMultiplexed
opt to combine stdout and stderr (#2452)db61369
Upgrade neo4j module to use features from v0.29.1 of testcontainers-go (#2463)2d89e90
bug:Fix AMQPS url (#2462)d24cf91
chore: more compose updates in commentsYou can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)