Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump @typescript-eslint/parser @typescript-eslint/eslint-plugin and eslint #580

Closed
wants to merge 1 commit into from

Conversation

ederign
Copy link
Member

@ederign ederign commented Nov 22, 2024

Description

In this PR:

  • bump @typescript-eslint/eslint-plugin from 8.13.0 to 8.14.0 in /clients/ui/frontend
  • @typescript-eslint/parser from 8.13.0 to 8.14.0 in /clients/ui/frontend
  • address cross-spawn CVE with npm audit

How Has This Been Tested?

npm install, npm build and start dev

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages; the author will squash them after approval or in case of manual merges will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from ederign. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ederign
Copy link
Member Author

ederign commented Dec 2, 2024

@Griffin-Sullivan PR updated.
npm install (kind-kubeflow-ui/default)
npm warn deprecated [email protected]: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
npm warn deprecated [email protected]: Use your platform's native atob() and btoa() methods instead
npm warn deprecated [email protected]: Rimraf versions prior to v4 are no longer supported
npm warn deprecated [email protected]: Rimraf versions prior to v4 are no longer supported
npm warn deprecated [email protected]: Rimraf versions prior to v4 are no longer supported
npm warn deprecated [email protected]: Glob versions prior to v9 are no longer supported
npm warn deprecated [email protected]: Glob versions prior to v9 are no longer supported
npm warn deprecated [email protected]: Use your platform's native DOMException instead

added 1513 packages, and audited 1514 packages in 11s

309 packages are looking for funding
run npm fund for details

found 0 vulnerabilities

@ederign ederign force-pushed the bump-deps-11-22-24 branch from 739ed3a to 44c2221 Compare December 2, 2024 13:32
@ederign ederign changed the title build(deps): bump @typescript-eslint/parser @typescript-eslint/eslint-plugin and fix cross-spawn CVE build(deps): bump @typescript-eslint/parser @typescript-eslint/eslint-plugin and eslint Dec 2, 2024
@ederign
Copy link
Member Author

ederign commented Dec 2, 2024

@Griffin-Sullivan ignore it for now (sorry for the noise). Due to the upgrade, we need to rework our client configs.

@ederign ederign closed this Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant