Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump logr dep to 1.4.2 #600

Closed
wants to merge 3 commits into from
Closed

chore: bump logr dep to 1.4.2 #600

wants to merge 3 commits into from

Conversation

Al-Pragliola
Copy link
Contributor

@Al-Pragliola Al-Pragliola commented Nov 28, 2024 •
edited
Loading

Description

Changed base for dependabot PR in order to show that it can be fixed by switching approach, it will be closed if the PR #598 will be rejected

How Has This Been Tested?

Run in ci + make test

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages; the author will squash them after approval or in case of manual merges will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.

Al-Pragliola and others added 3 commits November 27, 2024 19:09
@Al-Pragliola
fix(csi): make csi use mr version from go.mod in ci
062ae3f 
Signed-off-by: Alessio Pragliola <[email protected]>
@Al-Pragliola
chore(csi): bump mr version in go.mod file
73ac6f1 
Signed-off-by: Alessio Pragliola <[email protected]>
@dependabot @Al-Pragliola
build(deps): bump github.com/go-logr/logr from 1.4.1 to 1.4.2
c79c59b 
Bumps [github.com/go-logr/logr](https://github.com/go-logr/logr) from 1.4.1 to 1.4.2.
- [Release notes](https://github.com/go-logr/logr/releases)
- [Changelog](https://github.com/go-logr/logr/blob/master/CHANGELOG.md)
- [Commits](go-logr/logr@v1.4.1...v1.4.2)

---
updated-dependencies:
- dependency-name: github.com/go-logr/logr
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign tarilabs for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Al-Pragliola Al-Pragliola mentioned this pull request Nov 28, 2024
Closed
4 tasks
@google-oss-prow Google OSS Prow
Copy link

@Al-Pragliola: PRs cannot be closed as Not Planned.

In response to this:

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Al-Pragliola
Copy link
Contributor Author

Closing this as the parent PR will not be merged

@Al-Pragliola Al-Pragliola deleted the al-pragliola-bump-logr-1.4.2 branch November 29, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreyvelich andreyvelich Awaiting requested review from andreyvelich

@rareddy rareddy Awaiting requested review from rareddy

@tarilabs tarilabs Awaiting requested review from tarilabs

Assignees
No one assigned
Labels
Area/CSI Area/GitHub do-not-merge/work-in-progress size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Al-Pragliola