Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump @typescript-eslint/parser and @typescript-eslint/eslint-plugin from 8.13.0 to 8.17.0 in /clients/ui/frontend #631

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

ederign
Copy link
Member

@ederign ederign commented Dec 9, 2024

Description

In this PR:

  • clients/ui/frontend/package.json: bump @typescript-eslint/parser and @typescript-eslint/eslint-plugin from 8.13.0 to 8.17.0 in /clients/ui/frontend
  • clients/ui/frontend/src/shared/components/DashboardDescriptionListGroup.tsx to fix:

/Users/ederign/src/kubeflow/model-registry/clients/ui/frontend/src/shared/components/DashboardDescriptionListGroup.tsx
65:58 error 'title' may use Object's default stringification format ('[object Object]') when stringified @typescript-eslint/no-base-to-string
66:54 error 'title' may use Object's default stringification format ('[object Object]') when stringified @typescript-eslint/no-base-to-string
76:61 error 'title' may use Object's default stringification format ('[object Object]') when stringified @typescript-eslint/no-base-to-string
77:57 error 'title' may use Object's default stringification format ('[object Object]') when stringified @typescript-eslint/no-base-to-string
88:49 error 'title' may use Object's default stringification format ('[object Object]') when stringified @typescript-eslint/no-base-to-string
89:41 error 'title' may use Object's default stringification format ('[object Object]') when stringified @typescript-eslint/no-base-to-string

How Has This Been Tested?

Run the tests and quick sanity check on app.

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages; the author will squash them after approval or in case of manual merges will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.

…rom 8.13.0 to 8.17.0 in /clients/ui/frontend

Signed-off-by: Eder Ignatowicz <[email protected]>
@alexcreasy
Copy link
Contributor

/lgtm

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexcreasy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 6fe5f35 into kubeflow:main Dec 11, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants