Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps-dev): bump react-router-dom and react-router from 6.28.0 to 7.0.2 in /clients/ui/frontend #632

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

ederign
Copy link
Member

@ederign ederign commented Dec 9, 2024

Description

Fixing dependabot PR here: #627

We need to also upgrade react-router to keep aligned with react-router-dom.

How Has This Been Tested?

Run the tests and quick sanity check

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages; the author will squash them after approval or in case of manual merges will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.

…o 7.0.2 in /clients/ui/frontend

Signed-off-by: Eder Ignatowicz <[email protected]>
@ederign
Copy link
Member Author

ederign commented Dec 9, 2024

@Griffin-Sullivan @lucferbux @alexcreasy please let me know if we should bump react-router to a major version. We can also, as an option, stick with 6.x. I create this PR to fix the dependabot PR.

@alexcreasy
Copy link
Contributor

I say if react router 7 works let's go with it.

@alexcreasy
Copy link
Contributor

/lgtm

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexcreasy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit b046764 into kubeflow:main Dec 11, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants