Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix namespace selector #692

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

lucferbux
Copy link
Contributor

Description

Fix namespace selector in deployment, so it uses the kubeflow namespace selector from

How Has This Been Tested?

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages; the author will squash them after approval or in case of manual merges will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.

If you have UI changes

  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.
  • Verify that UI/UX changes conform the UX guidelines for Kubeflow.

console.error('Failed to initialize central dashboard client', err);
}
}
}, []);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it ok for us to use no dependencies here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no external dependency that will re-render, that's why our linter don't catch anything, this is used to initialization in the first render of the context.

Copy link
Contributor

@Griffin-Sullivan Griffin-Sullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We tested on the shared KF cluster and it works as expected.

@Griffin-Sullivan
Copy link
Contributor

As a note my PR #595 has changes for fixing the failing UI tests

@ederign
Copy link
Member

ederign commented Jan 10, 2025

@Griffin-Sullivan, so you mean to wait to merge #595 and then merge this one?

@lucferbux lucferbux force-pushed the fix-namespace-selector branch 2 times, most recently from 2c3c373 to 12830d4 Compare January 12, 2025 22:31
Signed-off-by: lucferbux <[email protected]>
@lucferbux lucferbux force-pushed the fix-namespace-selector branch from 12830d4 to c2daf94 Compare January 12, 2025 23:24
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Griffin-Sullivan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Griffin-Sullivan
Copy link
Contributor

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Jan 13, 2025
@google-oss-prow google-oss-prow bot merged commit b8dbf7b into kubeflow:main Jan 13, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants