-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix namespace selector #692
Fix namespace selector #692
Conversation
c68e627
to
bc34d6b
Compare
console.error('Failed to initialize central dashboard client', err); | ||
} | ||
} | ||
}, []); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it ok for us to use no dependencies here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no external dependency that will re-render, that's why our linter don't catch anything, this is used to initialization in the first render of the context.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We tested on the shared KF cluster and it works as expected.
As a note my PR #595 has changes for fixing the failing UI tests |
@Griffin-Sullivan, so you mean to wait to merge #595 and then merge this one? |
2c3c373
to
12830d4
Compare
Signed-off-by: lucferbux <[email protected]>
12830d4
to
c2daf94
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Griffin-Sullivan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Description
Fix namespace selector in deployment, so it uses the kubeflow namespace selector from
How Has This Been Tested?
Merge criteria:
DCO
check)If you have UI changes