Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bff): proper support for SPA routes #701

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

ederign
Copy link
Member

@ederign ederign commented Jan 14, 2025

Description

This PR sits on top #699 and does proper handling of SPA Routes.

In this PR: (specific commit a7448dd)

  • app.go: add a fallback if a path does not exist to app.config.StaticAssetsDir/index.html
  • app_test.go: test the fallback (we should not get a 404 like before).

How Has This Been Tested?

In the video, every time the UI blinks, I reload it. Also, pay attention that on /api/v1/something I still keep using our default api 404 page.

Kapture.2025-01-14.at.17.06.19.mp4

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)

Please merge #699 first!!!!

  • The commits have meaningful messages; the author will squash them after approval or in case of manual merges will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.

@ederign ederign changed the title feat(bff): proper support for SPA routes @ederign feat(bff): proper support for SPA routes Jan 14, 2025
@ederign
Copy link
Member Author

ederign commented Jan 15, 2025

@Griffin-Sullivan I just fixed the build.

@ederign
Copy link
Member Author

ederign commented Jan 16, 2025

@Griffin-Sullivan rebased!

Copy link
Contributor

@Griffin-Sullivan Griffin-Sullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me! Tested in Kubeflow.

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Griffin-Sullivan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Griffin-Sullivan
Copy link
Contributor

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Jan 16, 2025
@google-oss-prow google-oss-prow bot merged commit 7dcb477 into kubeflow:main Jan 16, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants