Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bump go deps to fix GO-2024-3333 #713

Merged
merged 1 commit into from
Jan 20, 2025
Merged

fix: bump go deps to fix GO-2024-3333 #713

merged 1 commit into from
Jan 20, 2025

Conversation

Al-Pragliola
Copy link
Contributor

Description

Bumping go deps to fix https://osv.dev/vulnerability/GO-2024-3333

How Has This Been Tested?

make test

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages; the author will squash them after approval or in case of manual merges will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.

@Al-Pragliola
fix: bump go deps to fix GO-2024-3333
becba2f 
Signed-off-by: Alessio Pragliola <[email protected]>
tarilabs
tarilabs approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @Al-Pragliola

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Jan 20, 2025
@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tarilabs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 76761f0 into kubeflow:main Jan 20, 2025
17 checks passed
@Al-Pragliola Al-Pragliola deleted the al-pragliola-fix-go-x-net-cve branch January 20, 2025 14:04
@tarilabs tarilabs mentioned this pull request Jan 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarilabs tarilabs tarilabs approved these changes

@andreyvelich andreyvelich Awaiting requested review from andreyvelich

@ckadner ckadner Awaiting requested review from ckadner

Assignees

@tarilabs tarilabs

Labels
approved lgtm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Al-Pragliola @tarilabs