Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nav, masthead): Edit navbar styling to handle dynamic window sizing #721

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

jenny-s51
Copy link
Contributor

@jenny-s51 jenny-s51 commented Jan 20, 2025

Edit navbar styling to handle dynamic window sizing.

Description

Adds media query to set proper margin on small viewports.

Tests N/A - styling updates only.

How Has This Been Tested?

  1. npm install and run Model Registry UI.

To run:

cd clients/ui/frontend && npm run start:dev   
cd clients/ui/bff && make run MOCK_K8S_CLIENT=true MOCK_MR_CLIENT=true
  1. Resize viewport to test updates.

Current:

Screen.Recording.2025-01-20.at.4.09.15.PM.mov

Kubeflow Central UI:

Kubeflow-Central-UI.mov

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages; the author will squash them after approval or in case of manual merges will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.

If you have UI changes

  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.
  • Verify that UI/UX changes conform the UX guidelines for Kubeflow.

Signed-off-by: Jenny <[email protected]>

remove left marign

fix masthead toggle alignment

fix comment

fix import order
Copy link
Contributor

@lucferbux lucferbux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Found one css issue but we can address that in a follow up, great work here @jenny-s51 thanks a lot!

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lucferbux

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants