-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial version of Catalog Service #725
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
da3cfea
to
f120c99
Compare
Signed-off-by: Dhiraj Bokde <[email protected]>
Signed-off-by: Dhiraj Bokde <[email protected]>
Signed-off-by: Dhiraj Bokde <[email protected]>
Signed-off-by: Dhiraj Bokde <[email protected]>
f120c99
to
ea8b1a0
Compare
Signed-off-by: Dhiraj Bokde <[email protected]>
c858615
to
6f329e9
Compare
Signed-off-by: Dhiraj Bokde <[email protected]>
…lementation scaffold Signed-off-by: Dhiraj Bokde <[email protected]>
Signed-off-by: Dhiraj Bokde <[email protected]>
Signed-off-by: Dhiraj Bokde <[email protected]>
098e54e
to
e27bc57
Compare
Signed-off-by: Dhiraj Bokde <[email protected]>
e27bc57
to
17f9d88
Compare
Signed-off-by: Dhiraj Bokde <[email protected]>
@@ -74,11 +104,23 @@ func init() { | |||
|
|||
proxyCmd.Flags().StringVar(&proxyCfg.MLMDHostname, "mlmd-hostname", proxyCfg.MLMDHostname, "MLMD hostname") | |||
proxyCmd.Flags().IntVar(&proxyCfg.MLMDPort, "mlmd-port", proxyCfg.MLMDPort, "MLMD port") | |||
|
|||
proxyCmd.Flags().StringVar(&proxyCfg.CatalogsConfigPath, "catalogs-path", proxyCfg.DisableService, "Path for Model Catalog source configuration yaml file") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
proxyCmd.Flags().StringVar(&proxyCfg.CatalogsConfigPath, "catalogs-path", proxyCfg.DisableService, "Path for Model Catalog source configuration yaml file") | |
proxyCmd.Flags().StringVar(&proxyCfg.CatalogsConfigPath, "catalogs-path", proxyCfg.CatalogConfigPath, "Path for Model Catalog source configuration yaml file") |
@@ -74,11 +104,23 @@ func init() { | |||
|
|||
proxyCmd.Flags().StringVar(&proxyCfg.MLMDHostname, "mlmd-hostname", proxyCfg.MLMDHostname, "MLMD hostname") | |||
proxyCmd.Flags().IntVar(&proxyCfg.MLMDPort, "mlmd-port", proxyCfg.MLMDPort, "MLMD port") | |||
|
|||
proxyCmd.Flags().StringVar(&proxyCfg.CatalogsConfigPath, "catalogs-path", proxyCfg.DisableService, "Path for Model Catalog source configuration yaml file") | |||
proxyCmd.Flags().StringVar(&proxyCfg.DisableService, "disable-service", proxyCfg.DisableService, "Optional name of service/endpoint to disable, can be either \"catalog\" or \"registry\"") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about making this two flags? Something along these lines:
proxyCmd.Flags().StringVar(&proxyCfg.DisableService, "disable-service", proxyCfg.DisableService, "Optional name of service/endpoint to disable, can be either \"catalog\" or \"registry\"") | |
proxyCmd.Flags().BoolVar(&proxyCfg.EnableRegistryService, "registry-service", true, "If true, start the registry service") | |
proxyCmd.Flags().BoolVar(&proxyCfg.EnableCatalogService, "catalog-service", true, "If true, start the catalog service") |
return nil, err | ||
} | ||
|
||
catalogs := make(map[string]ModelCatalogApi) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless there's an error, the final size of this map should be the number of catalogs:
catalogs := make(map[string]ModelCatalogApi) | |
catalogs := make(map[string]ModelCatalogApi, len(config.Catalogs)) |
Initial Version of Model Catalog Service
Description
Add a new Model Catalog service to model registry API. The API shares types with Model Registry service
to maximize the reuse of common properties.
How Has This Been Tested?
WIP
Merge criteria:
DCO
check)If you have UI changes