chore(bff): version bump for golang 1.22.2 -> 1.23.5, go lint v1.63.4 and k8s.io/apimachinery from 0.31.4 to 0.32.1 #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-oss-prow
bot
requested review from
andreyvelich,
Griffin-Sullivan and
lucferbux
|
This PR covers #712. |
|
@alexcreasy can you please take a look on this one? /assign @alexcreasy |
ederign
force-pushed
the
bff-version-bump
branch
2 times, most recently
from
f4a9a85 to
ae94aba
Compare
… and k8s.io/apimachinery from 0.31.4 to 0.32.1 Signed-off-by: Eder Ignatowicz <[email protected]>
ederign
force-pushed
the
bff-version-bump
branch
from
ae94aba to
712cff7
Compare
ederign
changed the title
4 tasks
lucferbux
approved these changes
Jan 23, 2025
alexcreasy
approved these changes
Jan 24, 2025
|
@tarilabs could you please merge this one for us? |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexcreasy, lucferbux, tarilabs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
k8s.io/apimachinery requires golang 1.23.5 (latest version), so I've decided to bump both.
golang bump required to bump lint version and also update the actions.
How Has This Been Tested?
Basic sanity check in the UI.
Merge criteria:
DCOcheck)