Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bff): bump golang base image in Dockerfile #742

Merged

Conversation

Al-Pragliola
Copy link
Contributor

@Al-Pragliola Al-Pragliola commented Jan 29, 2025

Description

Fixing error in https://github.com/kubeflow/model-registry/actions/runs/13016794276/job/36307908025

image

How Has This Been Tested?

run docker build locally

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages; the author will squash them after approval or in case of manual merges will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ederign

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ederign
Copy link
Member

ederign commented Jan 29, 2025

@Al-Pragliola, thank you so much for fixing this issue that I've introduced.

@ederign
Copy link
Member

ederign commented Jan 29, 2025

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Jan 29, 2025
@google-oss-prow google-oss-prow bot merged commit 66ea120 into kubeflow:main Jan 29, 2025
16 checks passed
@Al-Pragliola Al-Pragliola deleted the al-pragliola-fix-bff-dockerfile branch January 29, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants