feat: implement endpoint to support fetching workspace pod log - #1267
Open
YoyinZyc wants to merge 3 commits into
Open
feat: implement endpoint to support fetching workspace pod log#1267YoyinZyc wants to merge 3 commits into
YoyinZyc wants to merge 3 commits into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
YoyinZyc
force-pushed
the
log_batch
branch
2 times, most recently
from
July 21, 2026 19:50
f184804 to
fcb68f7
Compare
Member
… workspace pod log Signed-off-by: Yuchen Zhou <yczhou@google.com>
… level unit tests Signed-off-by: Yuchen Zhou <yczhou@google.com>
Signed-off-by: Yuchen Zhou <yczhou@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement the batch log API proposed in #886 (comment)
closes: #887
related: #886
Behavior
A new one-shot endpoint returning a workspace pods container(including the initContainer like istio) logs as a plain text.
Query params: container(defaults to first/primary container); tail(default to 1000); previous (default to false); sinceTime(default to none)
API
Response
Unit tests
internal/repositories/logs/repo_test.goworkspace_logs_handler_test.goTested Manually
BASE_URL=https://localhost:8443/workspaces/api/v1/workspaces/default/jupyterlab-workspace/podtemplate/logs/batch
Positive
Negative