Skip to content

fix: guard against undefined data volumes in workspace details view #1268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
christian-heusel wants to merge 1 commit into from
+5 −1
Closed

fix: guard against undefined data volumes in workspace details view #1268

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion workspaces/frontend/src/app/pages/Workspaces/WorkspaceResources.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,11 @@ interface WorkspaceResourcesProps {
}

export const WorkspaceResources: React.FC<WorkspaceResourcesProps> = ({ workspace }) => {
const workspaceDataVol = workspace.podTemplate.volumes.data;
// The generated type marks `data` as required, but the backend omits it when
// there's no data volume, so it can actually be undefined at runtime.
// TODO: This can be dropped once the frontend client is regenerated.
// eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
const workspaceDataVol = workspace.podTemplate.volumes.data ?? [];

@thaorell thaorell Jul 22, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is caused by a regression issue after PR #1119 was merged. This TypeScript failure is correct, due to the mismatching data contracts. The proper solution is re-generate the API client, fix and refactor any types to clear the issues. I have addressed this in #1272


const singleDataVolRenderer = (
data: {
Expand Down
Loading