Skip to content

Commit 5d76f7e

Browse files
fix: Refactor option imports flow
Signed-off-by: Abhijeet Dhumal <[email protected]>
1 parent eb3f1df commit 5d76f7e

File tree

4 files changed

+40
-7
lines changed

4 files changed

+40
-7
lines changed

kubeflow/trainer/backends/kubernetes/backend_test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
from kubeflow.trainer.backends.kubernetes.backend import KubernetesBackend
3636
import kubeflow.trainer.backends.kubernetes.utils as utils
3737
from kubeflow.trainer.constants import constants
38-
from kubeflow.trainer.options.kubernetes import (
38+
from kubeflow.trainer.options import (
3939
Annotations,
4040
Labels,
4141
SpecAnnotations,

kubeflow/trainer/backends/localprocess/backend_test.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,10 +26,10 @@
2626
LocalRuntimeTrainer,
2727
)
2828
from kubeflow.trainer.constants import constants
29-
from kubeflow.trainer.options import Name
30-
from kubeflow.trainer.options.kubernetes import (
29+
from kubeflow.trainer.options import (
3130
Annotations,
3231
Labels,
32+
Name,
3333
PodTemplateOverride,
3434
PodTemplateOverrides,
3535
)

kubeflow/trainer/options/__init__.py

Lines changed: 35 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,41 @@
1212
# See the License for the specific language governing permissions and
1313
# limitations under the License.
1414

15-
"""Common training options for the Kubeflow Trainer SDK."""
15+
"""Training options for the Kubeflow Trainer SDK.
16+
17+
All options are available from this single import location:
18+
from kubeflow.trainer.options import Name, Labels, PodTemplateOverrides, ...
19+
20+
Options self-validate their backend compatibility at runtime.
21+
Check each option's docstring for supported backends.
22+
"""
1623

1724
from kubeflow.trainer.options.common import Name
25+
from kubeflow.trainer.options.kubernetes import (
26+
Annotations,
27+
ContainerOverride,
28+
Labels,
29+
PodSpecOverride,
30+
PodTemplateOverride,
31+
PodTemplateOverrides,
32+
SpecAnnotations,
33+
SpecLabels,
34+
TrainerArgs,
35+
TrainerCommand,
36+
)
1837

19-
__all__ = ["Name"]
38+
__all__ = [
39+
# Common options (all backends)
40+
"Name",
41+
# Kubernetes options
42+
"Annotations",
43+
"ContainerOverride",
44+
"Labels",
45+
"PodSpecOverride",
46+
"PodTemplateOverride",
47+
"PodTemplateOverrides",
48+
"SpecAnnotations",
49+
"SpecLabels",
50+
"TrainerArgs",
51+
"TrainerCommand",
52+
]

kubeflow/trainer/options/kubernetes_test.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,11 @@
1818

1919
from kubeflow.trainer.backends.kubernetes.backend import KubernetesBackend
2020
from kubeflow.trainer.backends.localprocess.backend import LocalProcessBackend
21-
from kubeflow.trainer.options import Name
22-
from kubeflow.trainer.options.kubernetes import (
21+
from kubeflow.trainer.options import (
2322
Annotations,
2423
ContainerOverride,
2524
Labels,
25+
Name,
2626
PodTemplateOverride,
2727
PodTemplateOverrides,
2828
SpecAnnotations,

0 commit comments

Comments
 (0)