Skip to content

chore: add localprocess backend tests #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
+739 −5
Closed

chore: add localprocess backend tests #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a18de9
add localprocess backend tests
szaher Sep 15, 2025
c4c7883
fix ruff formatting
szaher Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,15 @@ uv-venv:
.PHONY: test-python
test-python: uv-venv
@uv sync
@uv run coverage run --source=kubeflow.trainer.backends.kubernetes.backend,kubeflow.trainer.utils.utils -m pytest ./kubeflow/trainer/backends/kubernetes/backend_test.py ./kubeflow/trainer/utils/utils_test.py
@uv run coverage report -m kubeflow/trainer/backends/kubernetes/backend.py kubeflow/trainer/utils/utils.py
@echo "Discovering all test files..."
@TEST_FILES=$$(find ./kubeflow -name "*_test.py" -type f | tr '\n' ' '); \
SOURCE_FILES=$$(find ./kubeflow -name "*_test.py" -type f | sed 's/_test\.py$$/.py/' | tr '\n' ' '); \
SOURCE_MODULES=$$(find ./kubeflow -name "*_test.py" -type f | sed 's/_test\.py$$/.py/' | sed 's|^\./||g' | sed 's|/|.|g' | sed 's|\.py$$||g' | tr '\n' ','); \
SOURCE_MODULES=$$(echo $$SOURCE_MODULES | sed 's/,$$//'); \
echo "Running tests: $$TEST_FILES"; \
echo "Coverage sources: $$SOURCE_MODULES"; \
uv run coverage run --source=$$SOURCE_MODULES -m pytest $$TEST_FILES; \
uv run coverage report -m $$(echo $$SOURCE_FILES | tr ' ' '\n' | grep -E '\.(py)$$' | tr '\n' ' ')
ifeq ($(report),xml)
@uv run coverage xml
else
Expand Down
6 changes: 3 additions & 3 deletions kubeflow/trainer/backends/localprocess/backend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,11 +61,11 @@ def get_runtime(self, name: str) -> types.Runtime:
return runtime

def get_runtime_packages(self, runtime: types.Runtime):
runtime = next((rt for rt in local_runtimes if rt.name == runtime.name), None)
if not runtime:
local_runtime = next((rt for rt in local_runtimes if rt.name == runtime.name), None)
if not local_runtime:
raise ValueError(f"Runtime '{runtime.name}' not found.")

return runtime.trainer.packages
return local_runtime.trainer.packages

def train(
self,
Expand Down
Loading