Skip to content

abort signal support via regenerating on new openapigen commit #2583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 22, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion settings
Original file line number Diff line number Diff line change
Expand Up @@ -30,4 +30,4 @@ export CLIENT_VERSION="0.8-SNAPSHOT"
# Name of the release package
export PACKAGE_NAME="@kubernetes/node-client"

export OPENAPI_GENERATOR_COMMIT=3e032bfcfd74b03f33fa5fb3d073286daf5cdbe1
export OPENAPI_GENERATOR_COMMIT=d06ed32df0a30fe12a1c7ba98722c12e867b6060
4 changes: 2 additions & 2 deletions src/gen/.openapi-generator/COMMIT

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion src/gen/http/http.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion src/watch.ts
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,10 @@ export class Watch {
const requestInit = await this.config.applyToFetchOptions({});

const controller = new AbortController();
const timeoutSignal = AbortSignal.timeout(30000);
requestInit.signal = AbortSignal.any([controller.signal, timeoutSignal]);
requestInit.signal = controller.signal as AbortSignal;
requestInit.method = 'GET';
requestInit.timeout = 30000;

let doneCalled: boolean = false;
const doneCallOnce = (err: any) => {
Expand Down
7 changes: 1 addition & 6 deletions tsconfig-with-tests.json
Original file line number Diff line number Diff line change
@@ -1,9 +1,4 @@
{
"extends": "./tsconfig.json",
"exclude": [],
"compilerOptions": {
"paths": {
"node-fetch/externals": ["./node_modules/@types/node-fetch/externals.d.ts"]
}
}
"exclude": []
}
5 changes: 1 addition & 4 deletions tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,7 @@
"importHelpers": true,
"skipLibCheck": true,
"esModuleInterop": true,
"useDefineForClassFields": false,
"paths": {
"node-fetch/externals": ["./node_modules/@types/node-fetch/externals.d.ts"]
}
"useDefineForClassFields": false
// enable this in the future
// "declarationMap": true
},
Expand Down