-
Notifications
You must be signed in to change notification settings - Fork 60
cleanup: Bump microsoft/wmi to 0.34.0 containing WMI method call fix (library version) #400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: library-development
Are you sure you want to change the base?
cleanup: Bump microsoft/wmi to 0.34.0 containing WMI method call fix (library version) #400
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: laozc The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @laozc. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
96a2fc1
to
a7f4365
Compare
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few comments LGTM
@@ -1,13 +1,17 @@ | |||
module github.com/kubernetes-csi/csi-proxy/v2 | |||
|
|||
go 1.22 | |||
go 1.24.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed that we should target the version that kubernetes/kubernetes is targetting, and it's targeting 1.24.5 so this is good.
No action items, just a comment to clarify why it's a good version.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
The WMI method call fix is released with microsoft/wmi @ 0.31.2.
This PR bumps this library and remove the workaround.
Which issue(s) this PR fixes:
Fixes #193
Special notes for your reviewer:
Refer to #394 for the change for standalone process.
Does this PR introduce a user-facing change?: