Skip to content

chore: Trim and remove whitespace and reformat #1084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

LaikaN57
Copy link

@LaikaN57 LaikaN57 commented Jul 18, 2025

Fixes #1075

user@host kubernetes-mixin % make prometheus_rules.yaml                                                                                    
user@host kubernetes-mixin % make prometheus_alerts.yaml 
user@host kubernetes-mixin % make test
  SUCCESS

  SUCCESS

  SUCCESS

  SUCCESS

  SUCCESS

@LaikaN57 LaikaN57 requested review from povilasv and skl as code owners July 18, 2025 05:20
Comment on lines -133 to -135
(windows_logical_disk_size_bytes{%(windowsExporterSelector)s}
- windows_logical_disk_free_bytes{%(windowsExporterSelector)s})
/ windows_logical_disk_size_bytes{%(windowsExporterSelector)s}
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reformatted to match other patterns in this file.

@@ -122,17 +122,18 @@
expr: |||
avg by (%(clusterLabel)s, instance) (
(irate(windows_logical_disk_read_seconds_total{%(windowsExporterSelector)s}[1m]) +
irate(windows_logical_disk_write_seconds_total{%(windowsExporterSelector)s}[1m]))
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Odd number of spaces.

@@ -346,7 +346,7 @@
)
, "workload", "", "owner_name")
, "workload_type", "", "owner_kind")

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line specifically fixes #1075.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: problems when rendering to YAML because of trailing whitespace
1 participant