-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Prometheus Annotations to the Node Service #2363
base: master
Are you sure you want to change the base?
Add Prometheus Annotations to the Node Service #2363
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @mdzraf. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
What type of PR is this?
/kind feature
What is this PR about? / Why do we need it?
Customer requested to be able to scrape the metrics from the drivers into CloudWatch Agent.
This PR Adds Prometheus annotations to the Node Service, this way metrics can be automatically discovered and scraped by Prometheus, enabling monitoring and observability of the node-level metrics through the CloudWatch agent.
How was this change tested?
Deploying driver with changes and ensuring that annotations were set by running
kubectl describe service ebs-csi-node -n kube-system
Does this PR introduce a user-facing change?