Adding Logs On How We Calculate CSINode.allocatables in NodeGetInfo #2372
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What is this PR about? / Why do we need it?
Today we log number of attached ENIs upon driver start if IMDS is our metadata source. However, we accidentally log it even if driver is in controller mode, which is an confusing experience for customers (Why should ebs-csi-controller care about the ENI count of the node it is on?)
This PR removes logging of ENIs when in controller mode and also adds logging of some of the information used to calculate CSI Node Allocatable, this way customers can have a better understanding of how this final node allocatable count was calculated.
How was this change tested?
Manually by spinning up a cluster and checking logs for nodes.
Logs output looks like this:
Does this PR introduce a user-facing change?