-
Notifications
You must be signed in to change notification settings - Fork 829
Adding Proper Handling of VAC Tags On Volume Creation #2457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @mdzraf. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
d1d79a8
to
b3b1123
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe worth adding a simple unit test? Otherwise /lgtm
Working on adding fix to be able to use string interpolation before merging |
b3b1123
to
9adf294
Compare
Can you also update the commit title to be more descriptive, for posterity. |
/retest |
Code Coverage Diff
|
9adf294
to
c9cee53
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Manually tested latest revision with the example manifests provided, works with string interpolation:
"Tags": [
{
"Key": "pvcnamespaceTEST",
"Value": "default"
},
{
"Key": "pvnameTEST",
"Value": "pvc-0287221a-8e65-4e11-8eff-1553a0c4e764"
},
{
"Key": "CSIVolumeName",
"Value": "pvc-0287221a-8e65-4e11-8eff-1553a0c4e764"
},
{
"Key": "kubernetes.io/created-for/pvc/name",
"Value": "ebs-claim"
},
....
/hold Waiting on decision to refactor tag templating logic |
New PR (#2470) to handle VAC and Controller tags on creation is replacing this one |
What type of PR is this?
/kind feature
What is this PR about? / Why do we need it?
This PR adds proper handling of creating a PVC with a specified volumeAttributesClassName so that the tags specified in the VAC are on the created volume.
Closes #2442
How was this change tested?
Used the following resource configurations and then ran
aws ec2 describe-volumes
with the createdvolume-id
to make sure that the tags specified in the VAC were added.Does this PR introduce a user-facing change?