Adding Proper Handling of VAC Tags On Volume Creation

[mdzraf]

What type of PR is this?

/kind feature

What is this PR about? / Why do we need it?

This PR adds proper handling of creating a PVC with a specified volumeAttributesClassName so that the tags specified in the VAC are on the created volume.

Closes #2442

How was this change tested?

Used the following resource configurations and then ran aws ec2 describe-volumes with the created volume-id to make sure that the tags specified in the VAC were added.

---
apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
  name: ebs-sc
provisioner: ebs.csi.aws.com
volumeBindingMode: WaitForFirstConsumer
---
apiVersion: v1
kind: PersistentVolumeClaim
metadata:
  name: ebs-claim
spec:
  accessModes:
    - ReadWriteOnce
  storageClassName: ebs-sc
  volumeAttributesClassName: io2-class
  resources:
    requests:
      storage: 10Gi
---
apiVersion: v1
kind: Pod
metadata:
  name: app
spec:
  containers:
  - name: app
    image: public.ecr.aws/amazonlinux/amazonlinux
    command: ["/bin/sh"]
    args: ["-c", "while true; do echo $(date -u) | tee /data/out.txt; sleep 5; done"]
    volumeMounts:
    - name: persistent-storage
      mountPath: /data
  volumes:
  - name: persistent-storage
    persistentVolumeClaim:
      claimName: ebs-claim
---
apiVersion: storage.k8s.io/v1beta1
kind: VolumeAttributesClass
metadata:
  name: io2-class
driverName: ebs.csi.aws.com
parameters:
  type: io2
  iops: "3000"
  tagSpecification_1: "pvcnamespaceTEST={{ .PVCNamespace }}"
  tagSpecification_2: "pvcnameTEST={{ .PVCName }}"
  tagSpecification_3: "pvnameTEST={{ .PVName }}"
  tagSpecification_4: "location=Seattle"
  tagSpecification_5: "cost-center="

Does this PR introduce a user-facing change?

Added Proper Handling To Ensure Tags Added in a VAC Which a PVC Points To Get Added to the Provisioned Volume

[k8s-ci-robot]

Hi @mdzraf. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ConnorJC3]

/ok-to-test

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from connorjc3. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ConnorJC3]

Maybe worth adding a simple unit test? Otherwise /lgtm

[mdzraf]

Working on adding fix to be able to use string interpolation before merging

[rdpsin]

Can you also update the commit title to be more descriptive, for posterity.

[mdzraf]

/retest

[github-actions]

Code Coverage Diff

File	Old Coverage	New Coverage	Delta
github.com/kubernetes-sigs/aws-ebs-csi-driver/pkg/driver/controller.go	83.8%	83.1%	-0.7

[torredil]

/lgtm

Manually tested latest revision with the example manifests provided, works with string interpolation:

"Tags": [
       {
            "Key": "pvcnamespaceTEST",
             "Value": "default"
       },
       {
           "Key": "pvnameTEST",
            "Value": "pvc-0287221a-8e65-4e11-8eff-1553a0c4e764"
        },
         {
             "Key": "CSIVolumeName",
              "Value": "pvc-0287221a-8e65-4e11-8eff-1553a0c4e764"
         },
         {
             "Key": "kubernetes.io/created-for/pvc/name",
              "Value": "ebs-claim"
         },
         ....

[mdzraf]

/hold Waiting on decision to refactor tag templating logic

[mdzraf]

New PR (#2470) to handle VAC and Controller tags on creation is replacing this one