-
Notifications
You must be signed in to change notification settings - Fork 1.6k
docs: add SubnetDiscoveryByReachability feature gate to values.yaml and feature-gates table #4331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…nd feature-gates table
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: nghiadaulau The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @nghiadaulau! |
Hi @nghiadaulau. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Issue
When creating an ALB without specifying subnets and without providing the annotation
alb.ingress.kubernetes.io/subnets
,the controller still automatically discovers and attaches subnets — even though those subnets are not tagged with
kubernetes.io/cluster/${cluster-name}
.This behavior comes from the
SubnetDiscoveryByReachability
feature gate, but it is not currently listed invalues.yaml
or the feature-gates documentation table.Description
This PR improves documentation and visibility of supported feature gates:
values.yaml:
Added a commented-out entry under
controllerConfig.featureGates
forSubnetDiscoveryByReachability
.This makes it easier for users to discover and configure this option directly in values without having to dig into the docs.
Feature Gates Table:
Added a new row for
SubnetDiscoveryByReachability
that explains how the controller automatically classifies subnets as public or private based on their route table configuration.This ensures consistency and parity with the actual supported feature gates.
These changes are purely documentation/UX improvements and do not modify any controller logic.
Checklist
README.md
, or thedocs
directory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯