Skip to content

Conversation

sanbyk
Copy link

@sanbyk sanbyk commented Sep 9, 2025

Issue

#4315

Description

This PR adds support for pods running on EKS Hybrid Nodes (on-premise). These nodes have no EC2 instance or VPC ENI and previously caused reconciliation failures when resolving pod endpoints and node instance IDs. The controller now detects hybrid nodes/pods, skips EC2-/ENI-specific logic, and reconciles TargetGroupBindings for hybrid endpoints.

Changes

Hybrid nodes detection

  • Update ExtractNodeInstanceID to recognize eks-hybrid ProviderID
  • Return a clearly non-EC2 instance identifier (special prefix) to:
    • Avoid accidental DescribeInstances calls
    • Keep a stable, non-empty key for logging/maps/metrics

Pod ENI resolution

  • Extend pod classification to include hybrid using eks.amazonaws.com/compute-type=hybrid
  • Skip ENI lookups entirely for hybrid pods; return placeholder ENI info to mark “no ENI”

Networking reconciliation

  • Skip backend Security Group resolution/management for hybrid endpoints, since there are no ENIs/SGs to manage

Node instance fetch

  • Exclude hybrid nodes from EC2 DescribeInstances fan-out in NodeInfoProvider

Tests

  • Add hybrid nodes focused unit tests for classification and resolution
  • Extend node instance ID extraction tests to cover eks-hybrid providerIDs

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sanbyk
Once this PR has been reviewed and has the lgtm label, please assign zac-nixon for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 9, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @sanbyk!

It looks like this is your first PR to kubernetes-sigs/aws-load-balancer-controller 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-load-balancer-controller has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 9, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @sanbyk. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 9, 2025
@sanbyk sanbyk changed the title Add support for EKS Hybrid Nodes feat: add EKS Hybrid Nodes support Sep 9, 2025
@shraddhabang
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 10, 2025
@shraddhabang shraddhabang self-assigned this Sep 10, 2025
@shuqz shuqz self-assigned this Sep 10, 2025
@malodie
Copy link

malodie commented Oct 3, 2025

Bump. We're waiting on this feature to move forward with hybrid nodes, as the aws-load-balancer-controller is the documented way (by AWS) to do ingress. It appears to work when we provision pods first on EC2, but then falls apart when the pods return to the hybrid state. I am also happy to test this in my working lab cluster once it releases (or before, if necessary).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants