-
Notifications
You must be signed in to change notification settings - Fork 1.6k
feat: add EKS Hybrid Nodes support #4336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sanbyk The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @sanbyk! |
Hi @sanbyk. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
Bump. We're waiting on this feature to move forward with hybrid nodes, as the aws-load-balancer-controller is the documented way (by AWS) to do ingress. It appears to work when we provision pods first on EC2, but then falls apart when the pods return to the hybrid state. I am also happy to test this in my working lab cluster once it releases (or before, if necessary). |
Issue
#4315
Description
This PR adds support for pods running on EKS Hybrid Nodes (on-premise). These nodes have no EC2 instance or VPC ENI and previously caused reconciliation failures when resolving pod endpoints and node instance IDs. The controller now detects hybrid nodes/pods, skips EC2-/ENI-specific logic, and reconciles TargetGroupBindings for hybrid endpoints.
Changes
Hybrid nodes detection
eks-hybrid
ProviderIDPod ENI resolution
eks.amazonaws.com/compute-type=hybrid
Networking reconciliation
Node instance fetch
Tests
Checklist
README.md
, or thedocs
directory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯