feat: Introduce annotation for setting explicit egress CIDR ranges on Service LB frontend security group

[mtweten]

Issue

Description

This PR implements a new annotation (service.beta.kubernetes.io/aws-load-balancer-outbound-cidrs) for Service load balancers to enable explicitly specifying a list of CIDR ranges to be added as egress rules to managed frontend security groups.

Currently, aws-load-balancer-controller doesn't set any explicit egress rules during SG creation, relying instead on AWS to create a default all-protocol 0.0.0.0/0 rule when no explicit egress rules are specified during SG creation. This egress rule is necessary for health checks on target groups, etc.

However, some organizations may have security scans that trigger on this 0.0.0.0/0 rule, and it would be desirable to be able to scope that down to a specific set of CIDR ranges instead (e.g. the VPC CIDR, for example). There is currently no mechanism in aws-load-balancer-controller to allow setting this, so that is what this is intended to provide.

Note that this only implements this for the Service load balancer (e.g. nlb) workflow. I wanted to keep the PR more narrowly scoped, but it would probably relatively simple to implement for other workflows as well. There is also the backend SG where a command flag would need to be introduced, but it's easy enough just to use a statically created SG for the backend SG using the existing mechanisms instead.

Checklist

• Added tests that cover your change (if possible)
• Added/modified documentation as required (such as the README.md, or the docs directory)
• Manually tested
• Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

• Backfilled missing tests for code in same general area 🎉
• Refactored something and made the world a better place 🌟

[linux-foundation-easycla]

• ✅login: mtweten / name: Michael Tweten / (c7cbffb)

The committers listed above are authorized under a signed CLA.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mtweten
Once this PR has been reviewed and has the lgtm label, please assign m00nf1sh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Welcome @mtweten!

It looks like this is your first PR to kubernetes-sigs/aws-load-balancer-controller 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-load-balancer-controller has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @mtweten. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[zac-nixon]

/ok-to-test