-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add conversion func for status-policy #637
Add conversion func for status-policy #637
Conversation
Hi @fsommar. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/unassign |
Thanks @fsommar /approve (Let's see if I have permissions here!) |
/assign seans3 |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fsommar, justinsb, mortent The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thank you @mortent! Can I get help with creating a tag to be used in kptdev/kpt#4129? cc @justinsb |
I'll be doing some other changes for watch filtering soon, so I'll cut a cli-utils release afterwards. |
As for kapply, I think adding a global flag is probably fine, if you add it and tests to exercise it. |
Pending that cli-utils release, will kptdev/kpt#4129 be accepted if it pins cli-utils to the merge commit of this change, even if there is no release that has this change yet? (We've been blocked on these PRs for over a month, and it doesn't feel like fun to block even more on some other, unrelated, work...) |
There's a v0.36.0 of cli-utils released. I've upgraded to that version in my PR in kptdev/kpt: kptdev/kpt@5c79264. |
Hi 👋
This change is intended for Kpt. We use
kpt live apply
in our CI/CD pipelines, but we don't need it saving statuses for all resources into the inventory. We want to be able to pass--status-policy=none
.I considered adding support for changing the status-policy flag in kapply as well, but I couldn't think of a way to introduce the flag without introducing it for all subcommands, or copying the description across for the applicable subcommands. Let me know if you want me to implement the flag here too.