Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conversion func for status-policy #637

Merged

Conversation

fsommar
Copy link
Contributor

@fsommar fsommar commented Mar 15, 2024

Hi 👋

This change is intended for Kpt. We use kpt live apply in our CI/CD pipelines, but we don't need it saving statuses for all resources into the inventory. We want to be able to pass --status-policy=none.

I considered adding support for changing the status-policy flag in kapply as well, but I couldn't think of a way to introduce the flag without introducing it for all subcommands, or copying the description across for the applicable subcommands. Let me know if you want me to implement the flag here too.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 15, 2024
@k8s-ci-robot k8s-ci-robot requested review from ash2k and karlkfi March 15, 2024 13:07
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 15, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @fsommar. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 15, 2024
@mortent
Copy link
Member

mortent commented Apr 15, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 15, 2024
@ash2k
Copy link
Member

ash2k commented Apr 20, 2024

/unassign

@justinsb
Copy link
Contributor

Thanks @fsommar

/approve
/lgtm

(Let's see if I have permissions here!)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 25, 2024
@tomasaschan
Copy link
Member

/assign seans3

@mortent
Copy link
Member

mortent commented May 4, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fsommar, justinsb, mortent

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 4, 2024
@k8s-ci-robot k8s-ci-robot merged commit 227a03f into kubernetes-sigs:master May 4, 2024
5 checks passed
@fsommar fsommar deleted the status-policy-conversion branch May 6, 2024 07:33
@fsommar
Copy link
Contributor Author

fsommar commented May 7, 2024

Thank you @mortent! Can I get help with creating a tag to be used in kptdev/kpt#4129?

cc @justinsb

@karlkfi
Copy link
Contributor

karlkfi commented May 8, 2024

I'll be doing some other changes for watch filtering soon, so I'll cut a cli-utils release afterwards.

@karlkfi
Copy link
Contributor

karlkfi commented May 8, 2024

As for kapply, I think adding a global flag is probably fine, if you add it and tests to exercise it.

@tomasaschan
Copy link
Member

Pending that cli-utils release, will kptdev/kpt#4129 be accepted if it pins cli-utils to the merge commit of this change, even if there is no release that has this change yet?

(We've been blocked on these PRs for over a month, and it doesn't feel like fun to block even more on some other, unrelated, work...)

@fsommar
Copy link
Contributor Author

fsommar commented May 13, 2024

There's a v0.36.0 of cli-utils released. I've upgraded to that version in my PR in kptdev/kpt: kptdev/kpt@5c79264.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants