Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump deps #641

Merged
merged 4 commits into from
Jun 20, 2024
Merged

Bump deps #641

merged 4 commits into from
Jun 20, 2024

Conversation

ash2k
Copy link
Member

@ash2k ash2k commented Jun 12, 2024

Please see individual commits.

Kubernetes 1.30 uses Go 1.22, so I updated the required Go version too.

I also ran an import formatter to fix the imports after the find/replace of the deprecated type. I hope it's ok. Formatter command was go run github.com/daixiang0/[email protected] write cmd pkg -s standard -s default.

Type import change rename - it's an alias, so the same type, and hence it's not a breaking change.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 12, 2024
@k8s-ci-robot k8s-ci-robot requested review from karlkfi and mortent June 12, 2024 05:19
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 12, 2024
@ash2k
Copy link
Member Author

ash2k commented Jun 12, 2024

Opened kubernetes/test-infra#32742 to bump the used Go version.

Copy link
Member

@mortent mortent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 17, 2024
@ash2k
Copy link
Member Author

ash2k commented Jun 17, 2024

/retest

This is not a breaking change since types are aliases
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 18, 2024
@mortent
Copy link
Member

mortent commented Jun 20, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 20, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ash2k, mortent

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 20, 2024
@k8s-ci-robot k8s-ci-robot merged commit 012918b into kubernetes-sigs:master Jun 20, 2024
5 checks passed
@ash2k ash2k deleted the bump-deps branch June 20, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants