Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubernetes 1.31.1 libraries #647

Merged
merged 2 commits into from
Nov 3, 2024
Merged

Conversation

ash2k
Copy link
Member

@ash2k ash2k commented Sep 18, 2024

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 18, 2024
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 18, 2024
@ash2k
Copy link
Member Author

ash2k commented Oct 9, 2024

PTAL @karlkfi @seans3

Copy link
Contributor

@seans3 seans3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I'll wait on Karl for a bit to ensure he's OK with it.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 28, 2024
@seans3
Copy link
Contributor

seans3 commented Oct 28, 2024

/assign @karlkfi

@ash2k
Copy link
Member Author

ash2k commented Nov 3, 2024

This is blocking me from updating some other dependencies in my project. Could someone merge this please?

@seans3
Copy link
Contributor

seans3 commented Nov 3, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ash2k, seans3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 3, 2024
@k8s-ci-robot k8s-ci-robot merged commit c241e71 into kubernetes-sigs:master Nov 3, 2024
5 checks passed
@ash2k ash2k deleted the k8s-1.31.1 branch November 3, 2024 09:46
@ash2k
Copy link
Member Author

ash2k commented Nov 3, 2024

Thank you, @seans3!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants