-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: clean up inventory Client interface #648
chore: clean up inventory Client interface #648
Conversation
Hi @sdowell. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/assign @karlkfi |
/ok-to-test |
e5e8470
to
bd0f1a4
Compare
The Client interface had several repetetive and/or extraneous methods which would make it more cumbersome to create different implementations of the interface. This trims down the interface to a core set of methods which are necessary for the applier.
bd0f1a4
to
8408301
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: karlkfi, sdowell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The Client interface had several repetetive and/or extraneous methods which would make it more cumbersome to create different implementations of the interface. This trims down the interface to a core set of methods which are necessary for the applier.
Removed Client methods: