Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump stringer to 0.29.0 #655

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

sdowell
Copy link
Contributor

@sdowell sdowell commented Feb 5, 2025

This bumps stringer to the latest version, which fixes some errors when running make generate.

This bumps stringer to the latest version, which fixes some errors when
running make generate.
@k8s-ci-robot k8s-ci-robot requested review from ash2k and seans3 February 5, 2025 00:02
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 5, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @sdowell. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 5, 2025
@ash2k
Copy link
Member

ash2k commented Feb 5, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 5, 2025
@ash2k
Copy link
Member

ash2k commented Feb 5, 2025

I'm getting lots of crashes with the current version. The new version works fine 👍

panic: runtime error: invalid memory address or nil pointer dereference [recovered]
        panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x2 addr=0x0 pc=0x100bd83e4]

goroutine 8 [running]:
go/types.(*Checker).handleBailout(0x14000dd0a80, 0x14000359bb8)
        /Users/mike/go/pkg/mod/golang.org/[email protected]/src/go/types/check.go:412 +0x9c
panic({0x100cea7c0?, 0x100e92820?})
        /Users/mike/go/pkg/mod/golang.org/[email protected]/src/runtime/panic.go:785 +0x124
go/types.(*StdSizes).Sizeof(0x0, {0x100d2b1d0, 0x100e95940})
        /Users/mike/go/pkg/mod/golang.org/[email protected]/src/go/types/sizes.go:229 +0x314
go/types.(*Config).sizeof(...)
        /Users/mike/go/pkg/mod/golang.org/[email protected]/src/go/types/sizes.go:334
go/types.representableConst.func1({0x100d2b1d0?, 0x100e95940?})
        /Users/mike/go/pkg/mod/golang.org/[email protected]/src/go/types/const.go:77 +0x90
go/types.representableConst({0x100d2ce88, 0x100e8b1a0}, 0x14000dd0a80, 0x100e95940, 0x14000359488)
        /Users/mike/go/pkg/mod/golang.org/[email protected]/src/go/types/const.go:93 +0x134
go/types.(*Checker).representation(0x14000dd0a80, 0x140004ef640, 0x100e95940)
        /Users/mike/go/pkg/mod/golang.org/[email protected]/src/go/types/const.go:257 +0x68
go/types.(*Checker).implicitTypeAndValue(0x14000dd0a80, 0x140004ef640, {0x100d2bbf8, 0x14000dda700})
        /Users/mike/go/pkg/mod/golang.org/[email protected]/src/go/types/expr.go:377 +0x304
go/types.(*Checker).assignment(0x14000dd0a80, 0x140004ef640, {0x100d2bbf8, 0x14000dda700}, {0x100c67b5b, 0x14})
        /Users/mike/go/pkg/mod/golang.org/[email protected]/src/go/types/assignments.go:70 +0x3ac
go/types.(*Checker).initConst(0x14000dd0a80, 0x140004bb9e0, 0x140004ef640)
        /Users/mike/go/pkg/mod/golang.org/[email protected]/src/go/types/assignments.go:144 +0x1f8
go/types.(*Checker).constDecl(0x14000dd0a80, 0x140004bb9e0, {0x100d2c148, 0x14000416100}, {0x100d2c148, 0x14000416120}, 0x0)
        /Users/mike/go/pkg/mod/golang.org/[email protected]/src/go/types/decl.go:482 +0x23c
go/types.(*Checker).objDecl(0x14000dd0a80, {0x100d2f118, 0x140004bb9e0}, 0x0)
        /Users/mike/go/pkg/mod/golang.org/[email protected]/src/go/types/decl.go:185 +0x840
go/types.(*Checker).packageObjects(0x14000dd0a80)
        /Users/mike/go/pkg/mod/golang.org/[email protected]/src/go/types/resolver.go:714 +0x3f0
go/types.(*Checker).checkFiles(0x14000dd0a80, {0x1400034c600, 0x5, 0x5})
        /Users/mike/go/pkg/mod/golang.org/[email protected]/src/go/types/check.go:467 +0x190
go/types.(*Checker).Files(0x140000f4000?, {0x1400034c600?, 0x1400097aba0?, 0x6?})
        /Users/mike/go/pkg/mod/golang.org/[email protected]/src/go/types/check.go:430 +0x80
golang.org/x/tools/go/packages.(*loader).loadPackage(0x140000f4000, 0x140001b1e60)
        /Users/mike/go/pkg/mod/golang.org/x/[email protected]/go/packages/packages.go:1058 +0x8b4
golang.org/x/tools/go/packages.(*loader).loadRecursive.func1()
        /Users/mike/go/pkg/mod/golang.org/x/[email protected]/go/packages/packages.go:854 +0x178
sync.(*Once).doSlow(0x0?, 0x0?)
        /Users/mike/go/pkg/mod/golang.org/[email protected]/src/sync/once.go:76 +0xf8
sync.(*Once).Do(...)
        /Users/mike/go/pkg/mod/golang.org/[email protected]/src/sync/once.go:67
golang.org/x/tools/go/packages.(*loader).loadRecursive(0x0?, 0x0?)
        /Users/mike/go/pkg/mod/golang.org/x/[email protected]/go/packages/packages.go:842 +0x48
golang.org/x/tools/go/packages.(*loader).refine.func2(0x0?)
        /Users/mike/go/pkg/mod/golang.org/x/[email protected]/go/packages/packages.go:777 +0x30
created by golang.org/x/tools/go/packages.(*loader).refine in goroutine 1
        /Users/mike/go/pkg/mod/golang.org/x/[email protected]/go/packages/packages.go:776 +0xa98

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 5, 2025
@sdowell
Copy link
Contributor Author

sdowell commented Feb 5, 2025

/assign @karlkfi

Copy link
Contributor

@karlkfi karlkfi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: karlkfi, sdowell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2025
@k8s-ci-robot k8s-ci-robot merged commit 0b116f9 into kubernetes-sigs:master Feb 6, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants