Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Add v1beta2 conditions to DevMachines with InMemory backend #11901

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

🌱 Add v1beta2 conditions to DevMachines with InMemory backend #11901

wants to merge 3 commits into from
+366 −9

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:

rif #11474

@fabriziopandini fabriziopandini added the area/provider/infrastructure-docker Issues or PRs related to the docker infrastructure provider label Feb 25, 2025
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 25, 2025
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 25, 2025
@fabriziopandini fabriziopandini mentioned this pull request Feb 25, 2025
Open
41 tasks
@sbueringer
Copy link
Member

/retest

Probably caused by this PR (I didn't take a closer look)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fabriziopandini fabriziopandini added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Feb 25, 2025
sbueringer
sbueringer reviewed Feb 25, 2025
View reviewed changes
Copy link
Member

@sbueringer sbueringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just constant naming & godoc nits

chrischdi
chrischdi reviewed Feb 27, 2025
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, maybe optional (in addition to stefan's :-) )

@fabriziopandini fabriziopandini force-pushed the add-v1beta2-conditions-to-DevMachine-InMemory branch from 9afcb01 to baf9705 Compare February 27, 2025 14:48
@k8s-ci-robot
Copy link
Contributor

@fabriziopandini: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-apidiff-main baf9705 link false /test pull-cluster-api-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

sbueringer
sbueringer reviewed Feb 28, 2025
View reviewed changes
Copy link
Member

@sbueringer sbueringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last round of nits. Thx for the patience, I know this level of nitpickery is maybe a bit too much for a Dev provider :)

api/v1beta1/v1beta2_condition_consts.go

// WaitingForClusterInfrastructureV1Beta2Reason documents an infra Machine waiting for the cluster
// infrastructure to be ready.
WaitingForClusterInfrastructureV1Beta2Reason = "WaitingForClusterInfrastructure"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
WaitingForClusterInfrastructureV1Beta2Reason = "WaitingForClusterInfrastructure"
WaitingForClusterInfrastructureReadyV1Beta2Reason = "WaitingForClusterInfrastructureReady"

I think that's a bit clearer and also consistent with WaitingForControlPlaneInitialized

(Just want to make sure these are fine, as I assume we would also use the same in production infra providers. For CAPDev it wouldn't matter too much of course)

test/infrastructure/docker/api/v1beta1/devmachine_types.go

// EtcdProvisioned condition and corresponding reasons that will be used in v1Beta2 API version for a DevMachine's in memory backend.
const (
// DevMachineInMemoryEtcdProvisionedV1Beta2Condition documents the status of the provisioning VM implementing the DevMachine's in memory backend.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// DevMachineInMemoryEtcdProvisionedV1Beta2Condition documents the status of the provisioning VM implementing the DevMachine's in memory backend.
// DevMachineInMemoryEtcdProvisionedV1Beta2Condition documents the status of the provisioning of the etcd instance hosted on the DevMachine's in memory backend.

(stole it from apiserver below)

test/infrastructure/docker/api/v1beta1/devmachine_types.go
// to be provisioned.
DevMachineInMemoryAPIServerWaitingForNodeProvisionedV1Beta2Reason = "WaitingForNodeProvisioned"

// DevMachineInMemoryAPIServerWaitingForStartupTimeoutV1Beta2Reason documents the infrastructure for a fake APIServer for a DevMachine's in memory backend provisioning.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// DevMachineInMemoryAPIServerWaitingForStartupTimeoutV1Beta2Reason documents the infrastructure for a fake APIServer for a DevMachine's in memory backend provisioning.
// DevMachineInMemoryAPIServerWaitingForStartupTimeoutV1Beta2Reason documents when the fake APIServer for a DevMachine's in memory backend
// is provisioning (it waits for a startup timeout).

(stole this from etcd)

test/infrastructure/docker/api/v1beta1/devmachine_types.go
// DevMachineInMemoryAPIServerWaitingForStartupTimeoutV1Beta2Reason documents the infrastructure for a fake APIServer for a DevMachine's in memory backend provisioning.
DevMachineInMemoryAPIServerWaitingForStartupTimeoutV1Beta2Reason = "WaitingForStartupTimeout"

// DevMachineInMemoryAPIServerProvisionedV1Beta2Reason documents a fake APIServer for a DevMachine's in memory backend being provisioned.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// DevMachineInMemoryAPIServerProvisionedV1Beta2Reason documents a fake APIServer for a DevMachine's in memory backend being provisioned.
// DevMachineInMemoryAPIServerProvisionedV1Beta2Reason documents when a fake APIServer for a DevMachine's in memory backend is fully provisioned.

(stole this from etcd)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrischdi chrischdi chrischdi left review comments

@sbueringer sbueringer sbueringer left review comments

@vincepri vincepri Awaiting requested review from vincepri

Assignees
No one assigned
Labels
area/provider/infrastructure-docker Issues or PRs related to the docker infrastructure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fabriziopandini @sbueringer @k8s-ci-robot @chrischdi