-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Enable requiredfields linter #11908
base: main
Are you sure you want to change the base?
Conversation
.golangci-kal.yml
Outdated
# requiredFields: | ||
# pointerPolicy: Warn | SuggestFix # Defaults to `SuggestFix`. We want our required fields to not be pointers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think best to leave the config "shadow" so that we can see what we could configure if we decided to change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed!
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Would be good to squash the commits for this PR, but otherwise LGTM |
Should I summarize the commits ? |
I think in this case we don't need the individual history of the changes on this branch. I'd encourage us to try and keep commits atomic. So if we are making fixups later, lets squash those into the commits earlier in the branch that introduced the bit that needed fixing (eg in this case, the first commit added some unwanted indentation, the second puts it back to how it was before, we should squash 2 into 1 here) |
Okay! |
On these kind of PRs I would expect just one commit. I'm also fine in general with just squashing via Prow if the first commit has an appropriate title |
bea3cf0
to
8d799a7
Compare
Signed-off-by: sivchari <[email protected]>
8d799a7
to
fcbaed5
Compare
/lgtm |
LGTM label has been added. Git tree hash: 1c3db99f4ded2ba33ae24c6ce3b4a6aa51458d5f
|
Needs rebase. Let's go ahead and merge this PR after rebase. But I would expect once we add required markers in the other PR this linter might show some findings in v1beta1. They should then be ignored (on that other PR) |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
Part of #11834
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
/area api