-
Notifications
You must be signed in to change notification settings - Fork 1.4k
✨ ClusterCache: Add GetUncachedClient() #12803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@bnallapeta: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Welcome @bnallapeta! |
Hi @bnallapeta. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
1eb12e4
to
66f5ea6
Compare
66f5ea6
to
a9c3cf3
Compare
Signed-off-by: Bharath Nallapeta <[email protected]>
a9c3cf3
to
6f2d5be
Compare
@bnallapeta: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@sbueringer I believe all the comments are addressed. Please take a look and let me know if there's anything else. Thank you. |
How do we handle the pull-cluster-api-apidiff-main that is failing? I get that its failing due to a API breaking change. But I could not find any file in the codebase where we can make it happy. |
The job is optional for merge. It's just to highlight API differences to reviewers so they can make an informed choice if the change is acceptable (which it is in this case) |
Thank you very much! /lgtm |
LGTM label has been added. Git tree hash: 21efe23c4328518176f1bd00b5b58e3a968f7cc6
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Adds GetUncachedClient method to the ClusterCache interface to support live (uncached) API calls to workload clusters. This helps reduce memory usage when you want to cache only a few types instead of having to exclude most types via DisableFor.
The uncached client is created alongside the cached one during connection setup and follows the same lifecycle (connect/disconnect).
Note: This introduces a breaking change to any existing implementations that are directly using ClusterCache.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #12784
/area controllers
/area clustercache