Skip to content

Conversation

ivelichkovich
Copy link
Contributor

@ivelichkovich ivelichkovich commented Oct 3, 2025

What this PR does / why we need it: Mitigates flaking test

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #12785

This adds CreateAndWait on machine creation in the TestReconcileMachinePhases envtests. Also adds a DeleteAndWait function for the test that runs the delete to check machine phase.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 3, 2025
@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-area PR is missing an area label needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 3, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @ivelichkovich. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ivelichkovich ivelichkovich changed the title flake TestReconcileMachinePhases 🌱 flake TestReconcileMachinePhases Oct 3, 2025
@sbueringer sbueringer changed the title 🌱 flake TestReconcileMachinePhases 🌱 Fix TestReconcileMachinePhases flake Oct 6, 2025
@sbueringer sbueringer added the area/machine Issues or PRs related to machine lifecycle management label Oct 6, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-area PR is missing an area label label Oct 6, 2025
@sbueringer
Copy link
Member

sbueringer commented Oct 6, 2025

Thank you!

/ok-to-test

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 6, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 6, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8436ab7a222e8cb940da81bcea8a38fe416fd30d

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 6, 2025
@k8s-ci-robot k8s-ci-robot merged commit 0105765 into kubernetes-sigs:main Oct 6, 2025
41 of 43 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.12 milestone Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/machine Issues or PRs related to machine lifecycle management cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Unit-test] Multiple test cases are failing in TestReconcileMachinePhases due to timeout

3 participants