-
Notifications
You must be signed in to change notification settings - Fork 119
Clarify that connections to EPP should use TLS by default #1085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify that connections to EPP should use TLS by default #1085
Conversation
@robscott: GitHub didn't allow me to request PR reviews from the following users: aslakknutsen, zetxqx. Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks @robscott . Just a nit, probably b/c my change is just merged.
@zetxqx: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
a748ab4
to
270bbfb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, added one nit
270bbfb
to
8a16f85
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, LiorLieberman, robscott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is intended to clarify the default expectation of using TLS when Gateways are connecting to Endpoint Picker(s). This matches the default mode of Endpoint Picker. While it leaves room for configuration of plain-text or other protocols altogether, I think it's sensible for the default behavior here to rely on TLS.
Thanks to @aslakknutsen for raising this as he was reviewing conformance tests earlier. Our conformance tests made this assumption of default behavior without any corresponding guidance in the API spec. This PR intends to resolve that.
/cc @danehans @LiorLieberman @aslakknutsen @zetxqx