Skip to content

test-report: istio 1.27-alpha v0.4.0 report 9/9 #1102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

test-report: istio 1.27-alpha v0.4.0 report 9/9 #1102

wants to merge 10 commits into from
+662 −0

Conversation

aslakknutsen
Copy link
Contributor

A start of something something

@LiorLieberman @keithmattix @zetxqx

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 1, 2025
@netlify Netlify
Copy link

netlify bot commented Jul 1, 2025 •
edited
Loading

✅ Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit d45d9db
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/6869b47302767800083c6697
😎 Deploy Preview https://deploy-preview-1102--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 1, 2025
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 1, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @aslakknutsen. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 1, 2025
@aslakknutsen aslakknutsen mentioned this pull request Jul 1, 2025
Open
nirrozenbaum
nirrozenbaum reviewed Jul 1, 2025
View reviewed changes
LiorLieberman
LiorLieberman approved these changes Jul 1, 2025
View reviewed changes
Copy link
Member

@LiorLieberman LiorLieberman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aslakknutsen!! this is great

conformance/reports/v0.4.0/gateway/istio/README.md Outdated

git clone [email protected]:kubernetes-sigs/gateway-api-inference-extension.git; cd gateway-api-inference-extension

#go test...
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be completed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure.. It's 1 README for potentially many reports, each report would have some kinda difference in the "go test" line so it's not possible to replicate fully. My initial feeling is; it's more of a guide to get you an env you can start running tests. What you want to test is up to you.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have you thought about having a Makefile within conformance dir with the different report options?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That could be an option.. hmm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aslakknutsen, LiorLieberman
Once this PR has been reviewed and has the lgtm label, please assign arangogutierrez for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

nirrozenbaum
nirrozenbaum reviewed Jul 1, 2025
View reviewed changes
conformance/reports/v0.4.0/gateway/istio/README.md

## Reproduce

```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

recommend to define GIE_VERSION variable and use it when accessing gie crds. it would probably be good to point to a specific version.

nirrozenbaum
nirrozenbaum reviewed Jul 1, 2025
View reviewed changes
conformance/reports/v0.4.0/gateway/istio/README.md Outdated

# gie conformance test suite

git clone [email protected]:kubernetes-sigs/gateway-api-inference-extension.git; cd gateway-api-inference-extension
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you mean to cd into conformance dir?

Suggested change
git clone [email protected]:kubernetes-sigs/gateway-api-inference-extension.git; cd gateway-api-inference-extension
git clone [email protected]:kubernetes-sigs/gateway-api-inference-extension.git; cd gateway-api-inference-extension/conformance

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe.. depends on the "go test" command. hehe

@ahg-g
Copy link
Contributor

ahg-g commented Jul 2, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 2, 2025
@zetxqx zetxqx mentioned this pull request Jul 2, 2025
Closed
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 4, 2025
@aslakknutsen
Copy link
Contributor Author

Guess what! .. I've got a fevah, ... and the only prescription.. is more cowbell!

More cowbell?

@aslakknutsen
feat: add kind env
aa43e7a 
Clean up some variable usage / exposure.
@LiorLieberman
Copy link
Member

@aslakknutsen Shuold we move this to be based on istio master branch?

@nirrozenbaum
Copy link
Contributor

@aslakknutsen Shuold we move this to be based on istio master branch?

@LiorLieberman does it mean Istio now supports GIE in master branch?

@LiorLieberman
Copy link
Member

LiorLieberman commented Jul 9, 2025 •
edited
Loading

@LiorLieberman does it mean Istio now supports GIE in master branch?

Yes - istio/istio#56845 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nirrozenbaum nirrozenbaum nirrozenbaum left review comments

@LiorLieberman LiorLieberman LiorLieberman approved these changes

@ahg-g ahg-g Awaiting requested review from ahg-g

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aslakknutsen @k8s-ci-robot @ahg-g @LiorLieberman @nirrozenbaum