feat: support envFrom and envVars #1183
Conversation
Signed-off-by: bitliu <[email protected]>
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Xunzhuo The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/L
| # Simple key-value environment variables | ||
| env: | ||
| SIMPLE_VAR: "simple-value" |
There was a problem hiding this comment.
what happens in the same var is defined in both places?
this could get confusing.
There was a problem hiding this comment.
++ Is it possible to fold env into envVars`?
| # values.yaml | ||
| inferenceExtension: | ||
| # Simple key-value environment variables | ||
| env: |
There was a problem hiding this comment.
Why not have env accept any yaml? then it's up to the user to use it properly.
E.g., in the epp-deployment template, env can have:
{{- toYaml . | nindent X }} # X should probably be 8
{{- end }}
The applying of a helm chart goes through Kubernetes validation in all cases. What do you think are the benefits of an explicit schema?
k8s-ci-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Fixes: #1117