-
Notifications
You must be signed in to change notification settings - Fork 148
Proposal for Multi-Cluster Inference Gateways #1374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bexxmodd The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @bexxmodd! |
Hi @bexxmodd. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/cc @robscott |
/ok-to-test |
@bexxmodd can you please remove the .DS_Store files? |
|
||
### Non-Goals | ||
|
||
Be overly prescriptive about implementation details - this should focus on the resulting UX and leave significant flexibility in how it is achieved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Each should be a bullet and end with a period.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having worked with MCS, my impression was that it was too prescriptive on some aspects (e.g., name sameness, IP addresses being routable across) and too open-ended in others (e.g., how to coordinate Exports/Imports).
Providing (at least) guidance on major interactions and design options would be helpful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
too prescriptive on some aspects (e.g., name sameness, IP addresses being routable across)
My impression is that namespace sameness has largely been proven to be a desirable constraint to facilitate sensible and safe routing between clusters in a trusted group (ClusterSet in MCS nomenclature) to avoid issues like default/api
in one cluster being a completely different workload than in another cluster in the group.
The challenge is that depending on the cluster ownership model (such as proliferation facilitated by managed Kubernetes offerings, where each team owns several of their own clusters rather than sharing a few centrally-managed clusters) or the namespace tenancy pattern used by an organization, avoiding naming conflicts can be difficult in larger organizations.
The question around sameness is more about whether there is a need to model and address services outside the trusted group into a cohesive Kubernetes networking model (versus external routing through ingress gateways). An example of this would be a large organization where an "accounts" and "billing" team might each own their own group of clusters for multi-region availability of the services they own, but need to route some requests outside of their domain to services owned by the other team in a different clusterset. In this organizational topology, it would be likely that some service names would conflict, being completely different logical workloads under a clashing common name (like api
, db
, or web
). Whether attempting to model these relationships in some sort of unified way through "mesh federation" is worthwhile may be an open question, but has been out of scope for MCS.
IP addresses are not required to be directly routable - single-network (direct routing) or multi-network (indirection through E/W gateways) are both acceptable implementations for the MCS API.
too open-ended in others (e.g., how to coordinate Exports/Imports)
MCS API was an early attempt to pivot from the issues with KubeFed trying to do too much as a full implementation, and instead just define the spec as an out-of-tree set of CRDs - a pattern which has seen success with Gateway API. There's some lack of precision here due to this being an early attempt, but the pattern has largely proven to be successful at facilitating an engaged community of implementations.
Providing (at least) guidance on major interactions and design options would be helpful.
If at some later point we would seriously consider a proposal for alternative 2️⃣ , starting from a provisional doc covering these interactions, constraints and user stories (including things missing from MCS like topology-aware routing or endpoint weighting inclusive of capacity/load reporting) must be a first step before we try jumping directly to a proposed API design.
|
||
## Proposal | ||
|
||
The multi-cluster Inference Gateway model will largely follow the multi-cluster services model, with a few key differences. We will omit DNS and ClusterIP resolution, and avoid a separate resource, e.g. ServiceExport, by inlining the concept within InferencePool. Additionally, we will add support for having separate Endpoint Pickers in each cluster. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we will add support for having separate Endpoint Pickers in each cluster.
Can you provide additional context here. Separate as in separate from the EPP ref'd by an InferencePool with an export annotation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How are remote clusters expected to learn of Exported/Imported InferencePool objects?
How will remote access to API masters be secured and coordinated over time?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How are remote clusters expected to learn of Exported/Imported InferencePool objects? How will remote access to API masters be secured and coordinated over time?
We'll be replicating how Multi-Cluster Service does that. Essentially extending Kubernetes' native service discovery across multiple clusters, creating a logical ClusterSet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW, the how part seems to be more to the implementation detail?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How are remote clusters expected to learn of Exported/Imported InferencePool objects?
The InferencePoolImport
resource should be created in each cluster in the ClusterSet in the same namespace and with the same name as any exported InferencePool
(likely automatically by some global controller, but details can be impl-specific), so that each cluster has a local reference resource to any exported remote InferencePool
.
How will remote access to API masters be secured and coordinated over time?
This is a big "details left to implementation" question regarding credentials, read/write access to clusters in a peer-to-peer or hub model, and push vs pull semantics.
#### InferencePool | ||
|
||
A new `inference.networking.k8s.io/export` annotation is added to InferencePool (replacement for ServiceExport resource in MCS). In the future this may become a field, but we’ll start with an annotation to allow for faster iteration. [We’ll avoid using a bool here to align with k8s API conventions](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#primitive-types). The supported values to start will be `Local` and `ClusterSet`. In the future, we may allow for some intermediate values such as Regional or domain-prefixed values. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should only start with ClusterSet
until a use case for Local
or any other supported value is accepted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For cluster-set, the assumption that inferenepool is replicated to all (or none) of the member clusters. There is no selective import/export (e.g., if resources in a cluster are maxed, what should it do with an imported pool?).
I think coordination of the export/import process (including, for example, status reporting) should be specified.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should only start with
ClusterSet
until a use case forLocal
or any other supported value is accepted.
Removed Local
.
For cluster-set, the assumption that inferenepool is replicated to all (or none) of the member clusters. There is no selective import/export (e.g., if resources in a cluster are maxed, what should it do with an imported pool?). I think coordination of the export/import process (including, for example, status reporting) should be specified.
I'm not sure I understand the question. Are you referring to how controller coordinates export/import? Also, we want to keep API changes as minimal as possible so we should leave some things open to the implementation details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Correct - I'm wondering if you want to recommend/enforce that import / export is done to all clusters in the ClusterSet or a controller is free to support selective sharing (e.g., whose policy specification is out of scope).
- How, if at all, are Import status reported on an Export? Is there an indication in the exported InferencePool that it was successfully imported and where? I don't consider those implementation details but part of the API. The controller should be able to coordinate across clusters so the user is aware of status (e.g., where is the import coming from, was the export successful, etc.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to clarify, clusterSet does not have the assumption that a service exists in all its members.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if you want to recommend/enforce that import / export is done to all clusters in the ClusterSet or a controller is free to support selective sharing (e.g., whose policy specification is out of scope).
I would discourage "selective sharing" as it can be a leaky abstraction to "non-sameness" in a clusterset (i.e. if default/api
is a different workload on clusters A and B, and selective sharing is used as a workaround to export the workload from cluster B to A and C, and separately from A to only B, it would be easy to quickly lose track of service identity.
How, if at all, are Import status reported on an Export? Is there an indication in the exported InferencePool that it was successfully imported and where? I don't consider those implementation details but part of the API. The controller should be able to coordinate across clusters so the user is aware of status (e.g., where is the import coming from, was the export successful, etc.)
This is the primary utility of status.conditions
on the ServiceExport resource (and status.clusters
on ServiceImport for "where is the import coming from") in MCS, although messaging conflicts or failed exports can be difficult for some implementations not using a centralized hub model. I think it's a valid question whether this is a required part of the API for an initial implementation, or if something like logs/metrics from a multi-cluster Gateway API Inference Extension controller is sufficient initially.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a proposed API spec for InferencePoolImport might help clarify some of these questions, like if/how it conveys addresses to reach remote EPPs or InferencePools or if it has any relationship/dependency on a local EPP?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW, I was thinking a potential use case for Local
might be to create a local InferencePoolImport resource to be able to incrementally migrate Gateways in the local cluster from a local InferencePool over to InferencePoolImport without exposing their local InferencePool to remote traffic yet (but now that I'm thinking about this more, the UX is actually a bit wonky because if the same name/namespace InferencePool on another cluster was already exported to the ClusterSet
, then traffic could still immediately start routing off-cluster, and would just additionally have local endpoints available, so maybe that's actually more confusing than helpful...)
|
||
1. Endpoint Pickers | ||
1. Model Server Endpoints | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
We should also consider routing to a remote EPP through a remote cluster Gateway (see the original design doc appendix).
-
Why does InferencePoolImport need to know about the model server endpoints in a remote cluster? I would expect the local Gateway to route to remote EPPs or through a remote Gateway based on one of the following conditions:
- A local InferencePool exists and no local GPUs are available, e.g. EPP returns a 503/429.
- A local InferencePool exists and the local Gateway decides the request is better served by an InferencePoolImport.
- No local InferencePool exists but an InferencePoolImport exists with a status that indicates available GPU resources.
Note: The EPP protocol spec should be updated when this design is finalized (please create a tracker issue).
|
||
#### Consider FailOpen “Extended” support for multi-cluster | ||
|
||
Given the potential complexity of supporting a FailOpen mode for multi-cluster, we could consider this “Extended” or optional support. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 on MC failover being "Extended" support.
|
||
#### Metrics from model server endpoints | ||
|
||
In the case where a Gateway is aware of all model server endpoints, it could theoretically also track metrics for each of these endpoints. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This duplicates the work of the EPP.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This duplicates the work of the EPP.
Isn't EPP tracking metrics for the individual pod? Maybe have Gateway collect aggregated metrics for InfPool?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed that this risks an unclear separation of concerns (or duplication of functionality) between a Gateway and EPP.
|
||
#### Metrics from Endpoint Picker | ||
|
||
Since Gateways are ultimately deciding which Endpoint Picker to send traffic to, it could make sense for Endpoint Pickers to report back load/utilization data to the Gateway to help inform that decision. (This would reflect the utilization of model server Pods within the local InferencePool managed by each EPP). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EPP already exposes InferencePool metrics. It will be up to the implementation on how to use these metrics to make a routing decision.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit confused here - how or in what circumstance would a Gateway potentially be evaluating InferencePool metrics to make routing decisions?
If multiple InferencePoolImport or InferencePool backendRefs are available under a single HTTPRouteRule, does this imply a need for some sort of dynamic weight
on backendRef
instead of static configuration? If an EPP is only called to select an endpoint after the target InferencePool has been selected, how would metrics be considered?
Would an HTTPRouteRule extensionRef filter potentially be useful for this selection somehow?
Is this the theoretical future enhancement referenced below and currently out of scope?
|
||
***Draft*** | ||
|
||
## Summary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've read the proposal. overall it looks very nice and at the very high level it could work (not getting into the details).
I think the main part that is still missing here is the motivation.
the only motivation that was mentioned in this doc is that the cluster may get out of resources.
I can share with you that this idea was proposed multiple times internally in IBM (much before GIE) but the answer was always the same - the cluster can be scaled with more resources and the complexity of spreading across multiple clusters doesn't worth it when looking at the tradeoff.
I would try to focus on this point - I think you need to find at least one use case or problem that cannot be solved by scaling the single cluster with more resources.
I think there is no doubt that this proposal adds complexity to GIE and there should be a real requirement or real use case for us to do that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with your perspective of adding any complexity should be justified and usually I'm the one who argues against it. However, in this case, there's a hard limit to how much resources can be scaled up vertically, so in the cloud environment that becomes only possible by adding new regions and scale horizontally. The expectation for the GWs is that this means adding new clusters. That's why there's a strong support for MC inference GW from other vendors like Microsoft, Red Hat, Solo, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's a hard limit to how much resources can be scaled up vertically
have you hit that limit in GCP?
it would be great to add that information as background to the proposal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Customers exhausting allocated GPU availability within a given region is a very real challenge across multiple cloud vendors currently.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Customers exhausting allocated GPU availability within a given region is a very real challenge across multiple cloud vendors currently.
I wasn't arguing otherwise :).
I was trying to stress a point - when GPU availability within a given region is exhausted, can a cloud vendor add more resources to that region? theoretically that's possible and solves the problem without the multi cluster complexity.
but scaling also has its limits. we can scale up to a certain limit. the question was if we know what that limit is, and if we can document it in order to understand what are the conditions where multi cluster becomes a better solution that scaling the single cluster.
adding this kind of information can strengthen the motivation section and help in understanding of whether we should invest in this use case or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I agree to add information about scalability for strengthening motivation. I'll do it in a general sense, as the specific numbers will very from provider to provider.
Currently, GKE Gateway limits to 1500 pods per regional clusters, and 500 pods per zonal clusters.
|
||
### Non-Goals | ||
|
||
Be overly prescriptive about implementation details - this should focus on the resulting UX and leave significant flexibility in how it is achieved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having worked with MCS, my impression was that it was too prescriptive on some aspects (e.g., name sameness, IP addresses being routable across) and too open-ended in others (e.g., how to coordinate Exports/Imports).
Providing (at least) guidance on major interactions and design options would be helpful.
|
||
### Why Multi-Cluster? | ||
|
||
Until now, Inference Gateways have been focused exclusively on routing to a single cluster. Unfortunately, the resources needed to run LLM workloads continue to be scarce, and the desired capacity is rarely available within a single cluster. To address this, we propose expanding InferencePool to support multi-cluster routing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is multi-cluster inference pools a gateway "thing" or gateway inference extension "thing" (e.g., EPP is responsible for delagating to a remote)?
I think the expectation is that gateways would support this directly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are the benefits for using multicluster inference pool vs a front-end routing layer that directs to the relevant gateways? Is it expected to provide better inference experience, a better UX, ...?
The introduction of multicluster (IP) routing is non-trivial. Adding Submariner (or some other overlay) could make for a complex system with non-trivial cost and failure modes. If we're leaning towards NOT routing directly to remote endpoints, the use of a gateway proxies creates a more robust and scalable system.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is multi-cluster inference pools a gateway "thing" or gateway inference extension "thing" (e.g., EPP is responsible for delagating to a remote)? I think the expectation is that gateways would support this directly?
MC Inference is part of the inference extension, rather than gateway just as InferencePool is.
Where's the expectation for it coming from? Is there a public thread or discussion?
To address your second questions in short, the idea of extending Inference Extension to support MC is motivated with the desire to make it as simple as possible for users. We don't want users manually configuring local Gateways.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bexxmodd Sorry for not being clear in phrasing the questions. Hope the below makes it clearer.
- I understand that the multicluster inferencing is part of IGW APIs and not the GW API. What I meant to ask was: in your view, which component should be implementing the handling of imported remote inference pools - is it the role of (1) an EPP, (2) the gateway implementation (e.g., by configuring Envoy) or (3) leaving it implementation dependent? Regarding the use of "expectation" - it was meant to confirm my reading of the design (i.e., that the gateway implementations would take on the role of handling the actual remote routing / traffic paths and it is not a feature of the EPP). There is no public thread or discussion - apologize for the confusion.
- there are multiple ways to solve this without having users manually configure gateways. For example, using GitOps to replicate the InferencePool along with a L7LB to select between clusters; a controller that configures Istio egress and ingress proxies, etc. The main point I'm trying to convey is that multicluster flat IP networks (ie. all pods across all clusters are directly routable from all clusters) can be a complex and fragile solution in many cloud and on premise deployments. Relying on the installation of a multicluster overlay (such as Submariner) makes the proposed multicluster inferencing solution depend on a third party tool to be viable and I don't think it would make users life easier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the expectation is that gateways would support this directly?
@bexxmodd I think I have the same confusion as @elevran. I understand that this proposal is about the high level spec on how we add resources similar to inferencePool (or extend it) to support MC inference. But the implementation will still be in the gateway controllers right? Or Is there a plan to allow someone to provide a standalone plug-in that can magically enable a non-mc inference aware GW to be able to route to multi-cluster inference endpoints?
|
||
## Proposal | ||
|
||
The multi-cluster Inference Gateway model will largely follow the multi-cluster services model, with a few key differences. We will omit DNS and ClusterIP resolution, and avoid a separate resource, e.g. ServiceExport, by inlining the concept within InferencePool. Additionally, we will add support for having separate Endpoint Pickers in each cluster. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How are remote clusters expected to learn of Exported/Imported InferencePool objects?
How will remote access to API masters be secured and coordinated over time?
#### InferencePool | ||
|
||
A new `inference.networking.k8s.io/export` annotation is added to InferencePool (replacement for ServiceExport resource in MCS). In the future this may become a field, but we’ll start with an annotation to allow for faster iteration. [We’ll avoid using a bool here to align with k8s API conventions](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#primitive-types). The supported values to start will be `Local` and `ClusterSet`. In the future, we may allow for some intermediate values such as Regional or domain-prefixed values. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For cluster-set, the assumption that inferenepool is replicated to all (or none) of the member clusters. There is no selective import/export (e.g., if resources in a cluster are maxed, what should it do with an imported pool?).
I think coordination of the export/import process (including, for example, status reporting) should be specified.
This API will be used almost exclusively for tracking endpoints, but unlike MCS, we actually have two distinct sets of endpoints that we could track: | ||
|
||
1. Endpoint Pickers | ||
1. Model Server Endpoints |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would routing directly to model server endpoints bypass the remote EPP? Does that imply that that EPP is operating with a partial view of resources in its cluster and their load? Is that reasonable/desirable?
|
||
## Implementation Details | ||
|
||
In the happy path, the only type of endpoint that a Gateway would need to know about is Endpoint Pickers. Ultimately, each Gateway will be sending requests to Endpoint Pickers, and then following the directions of that Endpoint Picker. As long as an Endpoint Picker is available, there’s no need to actually propagate the model server endpoints. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to suggest the following
- gateway in cluster A routes to EPP in cluster B
- EPP returns (e.g.,) a local endpoint in cluster B
- gateway in cluster A sends the request directly to endpoint in cluster B
This requires 2x RTT / BW and cross cluster coordination, routing... Couldn't GW(A) delegate to GW(B) and then leave the rest local to B?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Gateway in the cluster doesn't do any actual routing in single or multicluster. When the gateway resource in the cluster is created, the gateway controller creates Load Balancer resources, so when the request is sent by the client, it's received by the L7LB and routed to the EPP in the appropriate cluster. It's never actually routed to the cluster with the gateway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was referring to the L7LB in each cluster as "the Gateway", not the the Gateway resources in the k8s API.
Do you mean to say that there's an additional LB, besides Envoy/nginx/etc proxy, that is routing directly to the EPP service. or is it done via the proxy which is programmed via the Gateway API?
Also, LoadBalancer resources are often true of cloud deployment and not necessarily on-premise clusters,
|
||
### Why Multi-Cluster? | ||
|
||
Until now, Inference Gateways have been focused exclusively on routing to a single cluster. Unfortunately, the resources needed to run LLM workloads continue to be scarce, and the desired capacity is rarely available within a single cluster. To address this, we propose expanding InferencePool to support multi-cluster routing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the expectation is that gateways would support this directly?
@bexxmodd I think I have the same confusion as @elevran. I understand that this proposal is about the high level spec on how we add resources similar to inferencePool (or extend it) to support MC inference. But the implementation will still be in the gateway controllers right? Or Is there a plan to allow someone to provide a standalone plug-in that can magically enable a non-mc inference aware GW to be able to route to multi-cluster inference endpoints?
### Goals | ||
|
||
* Enable Inference Gateways to route to backends in multiple clusters. | ||
* Follow a pattern that is familiar to users of [Multi-Cluster Services (MCS)](https://multicluster.sigs.k8s.io/concepts/multicluster-services-api/) and/or Gateways. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder why this is a goal? What's the benefit of following that pattern? IIRC, we are not going to directly use the serviceExport/Import API and one of the non-goals is that we don't want to "be overly prescriptive about implementation details". So that leaves me scratching my head on which part of MCS we are actually following as we neither reuse the MCS API nor dictate implementation. The UX described below seems to be pretty generic that if someone would design it without ever knowing MCS probably would do something similar on a high level.
Just to be clear, I am not against it, but I am not sure if it has to be a goal. Also, I would agree more if the goal is that we have to use MCS since it's an some what established API multi-cluster networking protocol with implementations.
|
||
## Proposal | ||
|
||
The multi-cluster Inference Gateway model will largely follow the multi-cluster services model, with a few key differences. We will omit DNS and ClusterIP resolution, and avoid a separate resource, e.g. ServiceExport, by inlining the concept within InferencePool. Additionally, we will add support for having separate Endpoint Pickers in each cluster. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW, the how part seems to be more to the implementation detail?
#### InferencePool | ||
|
||
A new `inference.networking.k8s.io/export` annotation is added to InferencePool (replacement for ServiceExport resource in MCS). In the future this may become a field, but we’ll start with an annotation to allow for faster iteration. [We’ll avoid using a bool here to align with k8s API conventions](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#primitive-types). The supported values to start will be `Local` and `ClusterSet`. In the future, we may allow for some intermediate values such as Regional or domain-prefixed values. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to clarify, clusterSet does not have the assumption that a service exists in all its members.
|
||
## Implementation Details | ||
|
||
In the happy path, the only type of endpoint that a Gateway would need to know about is Endpoint Pickers. Ultimately, each Gateway will be sending requests to Endpoint Pickers, and then following the directions of that Endpoint Picker. As long as an Endpoint Picker is available, there’s no need to actually propagate the model server endpoints. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ultimately, each Gateway will be sending requests to Endpoint Pickers, and then following the directions of that Endpoint Picker.
I don't really follow this. So the gateway sends to many EPPs and somehow it follows a single EPP to the model server endpoints. How does the gateway pick which EPP to follow?
|
||
***Draft*** | ||
|
||
## Summary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this proposal would benefit from something that we've done a decent bit in Gateway API: an initial scoping doc that contains definitions, responsibilities, and use-cases that are explicitly out of scope. I want to understand why the inference extension should solve this vs. the gateway. What alternatives exist? Can we afford to assume pod to pod connectivity across all clusters? What are the exact boundaries. I think the what and why needs to be decided before we go too deep on the how
Initial design doc: https://docs.google.com/document/d/1QGvG9ToaJ72vlCBdJe--hmrmLtgOV_ptJi9D58QMD2w/edit?usp=sharing