Skip to content

Conversation

kfirtoledo
Copy link
Contributor

@kfirtoledo kfirtoledo commented Aug 14, 2025

This PR introduces two main enhancements:

  1. GetActivePods support in the plugin handle and datastore
  • Added GetActivePods() method to plugins.Handle interface.
  • Updated eppHandle to store and call a GetActivePodsFunc.
  • Implemented GetActivePods in the datastore to return the list of currently active pods.
  1. Remove deleted pod from prefix-cache scorer
  • Added RemovePod method to prefix.indexer to remove a pod
  • This enables cleanup of deleted pod after period of time that pod becomes inactive.

These changes allow plugins to query active pods directly from the handle and support cache cleanup for inactive pods in the prefix-cache scorer (Fix #1289)

Copy link

netlify bot commented Aug 14, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 62e4bd9
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/68b6a3937fa0f00008538bab
😎 Deploy Preview https://deploy-preview-1376--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 14, 2025
@k8s-ci-robot k8s-ci-robot requested review from ahg-g and liu-cong August 14, 2025 09:15
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 14, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @kfirtoledo. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 14, 2025
@kfirtoledo
Copy link
Contributor Author

/assign @nirrozenbaum

@kfirtoledo
Copy link
Contributor Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 14, 2025
@ahg-g
Copy link
Contributor

ahg-g commented Aug 14, 2025

@elevran is this aligned with the new datalayer APIs?

@elevran
Copy link
Contributor

elevran commented Aug 14, 2025

@elevran is this aligned with the new datalayer APIs?

I don't see a conflict - the datastore API is minimally affected.
Might be cleaner to allow registration for cleanup or Pod deletion instead of listing all Pods periodically, but this is not something I've touched in the data layer yet (plan to refactor the k8s data sources as well, as we discussed on the original design issue).

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 19, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kfirtoledo
Once this PR has been reviewed and has the lgtm label, please ask for approval from nirrozenbaum. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 24, 2025
@liu-cong
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 28, 2025
@liu-cong
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 28, 2025
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 2, 2025
@liu-cong
Copy link
Contributor

liu-cong commented Sep 2, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prefix-cache-scorer does not handle pod delete
6 participants